Skip to content

🍒 8902 - Ensure auto-detected service name is the same for every process in the same build #8930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

🍒 8902 - Ensure auto-detected service name is the same for every process in the same build #8930

wants to merge 1 commit into from

Conversation

nikita-tkachenko-datadog
Copy link
Contributor

Backport #8902 to release/v1.49.x

@nikita-tkachenko-datadog nikita-tkachenko-datadog added type: bug Bug report and fix comp: ci visibility Continuous Integration Visibility labels Jun 5, 2025
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review June 5, 2025 11:43
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested review from a team as code owners June 5, 2025 11:43
@nikita-tkachenko-datadog nikita-tkachenko-datadog added this to the 1.49.1 milestone Jun 5, 2025
@nikita-tkachenko-datadog nikita-tkachenko-datadog enabled auto-merge (squash) June 5, 2025 11:47
@pr-commenter
Copy link

pr-commenter bot commented Jun 5, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita.tkachenko/backport-pr-8902
git_commit_date 1749044153 1749123725
git_commit_sha 7787af7 1191be5
release_version 1.50.0-SNAPSHOT~7787af738f 1.50.0-SNAPSHOT~1191be52bd
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1749126921 1749126921
ci_job_id 969622586 969622586
ci_pipeline_id 67046116 67046116
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-o6ycphvs-project-304-concurrent-2-1271qbn8 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-o6ycphvs-project-304-concurrent-2-1271qbn8 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 5 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:tracing:AppSec better
[-6.587ms; -1.244ms] or [-11.227%; -2.121%]		 54.757ms 58.672ms
scenario:startup:petclinic:profiling:ProfilingAgent better
[-8.285ms; -5.141ms] or [-8.033%; -4.984%]		 96.431ms 103.144ms
scenario:startup:petclinic:profiling:GlobalTracer worse
[+17.272ms; +24.811ms] or [+4.785%; +6.873%]		 382.042ms 361.000ms
scenario:startup:petclinic:profiling:AppSec better
[-7.842ms; -7.085ms] or [-12.770%; -11.537%]		 53.947ms 61.410ms
scenario:startup:petclinic:profiling:Profiling better
[-8.286ms; -5.140ms] or [-8.032%; -4.983%]		 96.454ms 103.167ms
scenario:startup:petclinic:tracing:Remote Config better
[-58.495µs; -15.844µs] or [-7.808%; -2.115%]		 711.976µs 749.145µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030102
Total [baseline] (8.543 s) : 0, 8542588
Agent [candidate] (1.006 s) : 0, 1005988
Total [candidate] (8.492 s) : 0, 8492313
section iast
Agent [baseline] (1.151 s) : 0, 1150900
Total [baseline] (9.194 s) : 0, 9193920
Agent [candidate] (1.136 s) : 0, 1136281
Total [candidate] (9.225 s) : 0, 9224936
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.149 s) : 0, 1148594
Total [baseline] (9.156 s) : 0, 9155855
Agent [candidate] (1.149 s) : 0, 1149300
Total [candidate] (9.276 s) : 0, 9275731
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1151552
Total [baseline] (9.211 s) : 0, 9210649
Agent [candidate] (1.134 s) : 0, 1134262
Total [candidate] (9.202 s) : 0, 9201979
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.03 s -
Agent iast 1.151 s 120.798 ms (11.7%)
Agent iast_HARDCODED_SECRET_DISABLED 1.149 s 118.492 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.152 s 121.45 ms (11.8%)
Total tracing 8.543 s -
Total iast 9.194 s 651.331 ms (7.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.156 s 613.267 ms (7.2%)
Total iast_TELEMETRY_OFF 9.211 s 668.06 ms (7.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.006 s -
Agent iast 1.136 s 130.293 ms (13.0%)
Agent iast_HARDCODED_SECRET_DISABLED 1.149 s 143.312 ms (14.2%)
Agent iast_TELEMETRY_OFF 1.134 s 128.275 ms (12.8%)
Total tracing 8.492 s -
Total iast 9.225 s 732.623 ms (8.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.276 s 783.418 ms (9.2%)
Total iast_TELEMETRY_OFF 9.202 s 709.666 ms (8.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.804 ms) : 0, 687804
BytebuddyAgent [candidate] (669.08 ms) : 0, 669080
GlobalTracer [baseline] (241.541 ms) : 0, 241541
GlobalTracer [candidate] (239.457 ms) : 0, 239457
AppSec [baseline] (58.672 ms) : 0, 58672
AppSec [candidate] (54.757 ms) : 0, 54757
Debugger [baseline] (6.211 ms) : 0, 6211
Debugger [candidate] (6.265 ms) : 0, 6265
Remote Config [baseline] (740.887 µs) : 0, 741
Remote Config [candidate] (738.911 µs) : 0, 739
Telemetry [baseline] (11.416 ms) : 0, 11416
Telemetry [candidate] (12.232 ms) : 0, 12232
section iast
BytebuddyAgent [baseline] (802.643 ms) : 0, 802643
BytebuddyAgent [candidate] (789.372 ms) : 0, 789372
GlobalTracer [baseline] (230.995 ms) : 0, 230995
GlobalTracer [candidate] (229.822 ms) : 0, 229822
IAST [baseline] (25.325 ms) : 0, 25325
IAST [candidate] (22.945 ms) : 0, 22945
AppSec [baseline] (53.979 ms) : 0, 53979
AppSec [candidate] (56.452 ms) : 0, 56452
Debugger [baseline] (5.931 ms) : 0, 5931
Debugger [candidate] (5.882 ms) : 0, 5882
Remote Config [baseline] (603.928 µs) : 0, 604
Remote Config [candidate] (597.137 µs) : 0, 597
Telemetry [baseline] (7.878 ms) : 0, 7878
Telemetry [candidate] (7.85 ms) : 0, 7850
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.526 ms) : 0, 800526
BytebuddyAgent [candidate] (797.248 ms) : 0, 797248
GlobalTracer [baseline] (230.053 ms) : 0, 230053
GlobalTracer [candidate] (233.244 ms) : 0, 233244
IAST [baseline] (27.381 ms) : 0, 27381
IAST [candidate] (23.282 ms) : 0, 23282
AppSec [baseline] (52.624 ms) : 0, 52624
AppSec [candidate] (57.34 ms) : 0, 57340
Debugger [baseline] (5.967 ms) : 0, 5967
Debugger [candidate] (6.033 ms) : 0, 6033
Remote Config [baseline] (606.589 µs) : 0, 607
Remote Config [candidate] (606.664 µs) : 0, 607
Telemetry [baseline] (7.991 ms) : 0, 7991
Telemetry [candidate] (7.977 ms) : 0, 7977
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (803.108 ms) : 0, 803108
BytebuddyAgent [candidate] (787.656 ms) : 0, 787656
GlobalTracer [baseline] (230.832 ms) : 0, 230832
GlobalTracer [candidate] (230.46 ms) : 0, 230460
IAST [baseline] (27.429 ms) : 0, 27429
IAST [candidate] (22.352 ms) : 0, 22352
AppSec [baseline] (52.007 ms) : 0, 52007
AppSec [candidate] (56.054 ms) : 0, 56054
Debugger [baseline] (6.039 ms) : 0, 6039
Debugger [candidate] (5.925 ms) : 0, 5925
Remote Config [baseline] (628.039 µs) : 0, 628
Remote Config [candidate] (612.888 µs) : 0, 613
Telemetry [baseline] (7.913 ms) : 0, 7913
Telemetry [candidate] (7.762 ms) : 0, 7762
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026978
Total [baseline] (11.172 s) : 0, 11171605
Agent [candidate] (1.014 s) : 0, 1014194
Total [candidate] (11.142 s) : 0, 11141969
section appsec
Agent [baseline] (1.169 s) : 0, 1168552
Total [baseline] (11.254 s) : 0, 11254311
Agent [candidate] (1.152 s) : 0, 1151742
Total [candidate] (11.209 s) : 0, 11208650
section iast
Agent [baseline] (1.151 s) : 0, 1150921
Total [baseline] (11.403 s) : 0, 11403396
Agent [candidate] (1.138 s) : 0, 1137857
Total [candidate] (11.285 s) : 0, 11284506
section profiling
Agent [baseline] (1.27 s) : 0, 1270398
Total [baseline] (11.514 s) : 0, 11514346
Agent [candidate] (1.265 s) : 0, 1265280
Total [candidate] (11.51 s) : 0, 11510090
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.027 s -
Agent appsec 1.169 s 141.574 ms (13.8%)
Agent iast 1.151 s 123.943 ms (12.1%)
Agent profiling 1.27 s 243.42 ms (23.7%)
Total tracing 11.172 s -
Total appsec 11.254 s 82.706 ms (0.7%)
Total iast 11.403 s 231.791 ms (2.1%)
Total profiling 11.514 s 342.741 ms (3.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.014 s -
Agent appsec 1.152 s 137.548 ms (13.6%)
Agent iast 1.138 s 123.663 ms (12.2%)
Agent profiling 1.265 s 251.086 ms (24.8%)
Total tracing 11.142 s -
Total appsec 11.209 s 66.681 ms (0.6%)
Total iast 11.285 s 142.536 ms (1.3%)
Total profiling 11.51 s 368.121 ms (3.3%) 
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.363 ms) : 0, 684363
BytebuddyAgent [candidate] (674.38 ms) : 0, 674380
GlobalTracer [baseline] (240.937 ms) : 0, 240937
GlobalTracer [candidate] (239.997 ms) : 0, 239997
AppSec [baseline] (56.59 ms) : 0, 56590
AppSec [candidate] (54.746 ms) : 0, 54746
Debugger [baseline] (6.244 ms) : 0, 6244
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (749.145 µs) : 0, 749
Remote Config [candidate] (711.976 µs) : 0, 712
Telemetry [baseline] (14.427 ms) : 0, 14427
Telemetry [candidate] (14.405 ms) : 0, 14405
section appsec
BytebuddyAgent [baseline] (704.699 ms) : 0, 704699
BytebuddyAgent [candidate] (690.33 ms) : 0, 690330
GlobalTracer [baseline] (238.281 ms) : 0, 238281
GlobalTracer [candidate] (236.82 ms) : 0, 236820
AppSec [baseline] (176.353 ms) : 0, 176353
AppSec [candidate] (174.979 ms) : 0, 174979
Debugger [baseline] (5.998 ms) : 0, 5998
Debugger [candidate] (5.908 ms) : 0, 5908
Remote Config [baseline] (635.654 µs) : 0, 636
Remote Config [candidate] (616.521 µs) : 0, 617
Telemetry [baseline] (7.828 ms) : 0, 7828
Telemetry [candidate] (8.567 ms) : 0, 8567
IAST [baseline] (22.063 ms) : 0, 22063
IAST [candidate] (21.89 ms) : 0, 21890
section iast
BytebuddyAgent [baseline] (802.232 ms) : 0, 802232
BytebuddyAgent [candidate] (790.174 ms) : 0, 790174
GlobalTracer [baseline] (230.486 ms) : 0, 230486
GlobalTracer [candidate] (230.649 ms) : 0, 230649
AppSec [baseline] (53.0 ms) : 0, 53000
AppSec [candidate] (56.695 ms) : 0, 56695
Debugger [baseline] (6.015 ms) : 0, 6015
Debugger [candidate] (5.864 ms) : 0, 5864
Remote Config [baseline] (617.68 µs) : 0, 618
Remote Config [candidate] (584.44 µs) : 0, 584
Telemetry [baseline] (8.036 ms) : 0, 8036
Telemetry [candidate] (7.864 ms) : 0, 7864
IAST [baseline] (26.962 ms) : 0, 26962
IAST [candidate] (22.595 ms) : 0, 22595
section profiling
ProfilingAgent [baseline] (103.144 ms) : 0, 103144
ProfilingAgent [candidate] (96.431 ms) : 0, 96431
BytebuddyAgent [baseline] (679.019 ms) : 0, 679019
BytebuddyAgent [candidate] (667.434 ms) : 0, 667434
GlobalTracer [baseline] (361.0 ms) : 0, 361000
GlobalTracer [candidate] (382.042 ms) : 0, 382042
AppSec [baseline] (61.41 ms) : 0, 61410
AppSec [candidate] (53.947 ms) : 0, 53947
Debugger [baseline] (6.035 ms) : 0, 6035
Debugger [candidate] (6.114 ms) : 0, 6114
Remote Config [baseline] (653.587 µs) : 0, 654
Remote Config [candidate] (663.554 µs) : 0, 664
Telemetry [baseline] (8.111 ms) : 0, 8111
Telemetry [candidate] (8.131 ms) : 0, 8131
Profiling [baseline] (103.167 ms) : 0, 103167
Profiling [candidate] (96.454 ms) : 0, 96454
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-06-05T12:04:52 2025-06-05T12:13:57
git_branch master nikita.tkachenko/backport-pr-8902
git_commit_date 1749044153 1749123725
git_commit_sha 7787af7 1191be5
release_version 1.50.0-SNAPSHOT~7787af738f 1.50.0-SNAPSHOT~1191be52bd
start_time 2025-06-05T12:04:38 2025-06-05T12:13:42
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1749126126 1749126126
ci_job_id 969622587 969622587
ci_pipeline_id 67046116 67046116
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-i3wcqa5q-project-304-concurrent-1-2trnc7ul 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-i3wcqa5q-project-304-concurrent-1-2trnc7ul 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
thresholds_or_results results results
variant iast iast

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 5 metrics, 21 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:appsec_no_iast worse
[+451.545µs; +568.276µs] or [+4.661%; +5.866%]		 unstable
[-59.566op/s; +7.067op/s] or [-11.690%; +1.387%]		 10.197ms 483.305op/s 9.687ms 509.554op/s
scenario:load:petclinic:no_agent worse
[+849.336µs; +956.909µs] or [+8.945%; +10.078%]		 unstable
[-72.859op/s; -13.721op/s] or [-14.025%; -2.641%]		 10.398ms 476.190op/s 9.495ms 519.481op/s

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master nikita.tkachenko/backport-pr-8902
git_commit_date 1749044153 1749123725
git_commit_sha 7787af7 1191be5
release_version 1.50.0-SNAPSHOT~7787af738f 1.50.0-SNAPSHOT~1191be52bd
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1749126455 1749126455
ci_job_id 969622588 969622588
ci_pipeline_id 67046116 67046116
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-o6ycphvs-project-304-concurrent-3-87orwbqw 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-o6ycphvs-project-304-concurrent-3-87orwbqw 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.398 ms) : 2349, 2447
.   : milestone, 2398,
iast (2.195 ms) : 2132, 2257
.   : milestone, 2195,
iast_GLOBAL (2.228 ms) : 2166, 2291
.   : milestone, 2228,
profiling (2.032 ms) : 1982, 2082
.   : milestone, 2032,
tracing (2.018 ms) : 1970, 2067
.   : milestone, 2018,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.4 ms) : 2350, 2449
.   : milestone, 2400,
iast (2.183 ms) : 2122, 2245
.   : milestone, 2183,
iast_GLOBAL (2.227 ms) : 2165, 2289
.   : milestone, 2227,
profiling (2.026 ms) : 1977, 2076
.   : milestone, 2026,
tracing (2.008 ms) : 1960, 2056
.   : milestone, 2008,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.398 ms [2.349 ms, 2.447 ms] 924.542 µs (62.7%)
iast 2.195 ms [2.132 ms, 2.257 ms] 721.155 µs (48.9%)
iast_GLOBAL 2.228 ms [2.166 ms, 2.291 ms] 755.016 µs (51.2%)
profiling 2.032 ms [1.982 ms, 2.082 ms] 558.742 µs (37.9%)
tracing 2.018 ms [1.97 ms, 2.067 ms] 544.894 µs (37.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.461 ms, 1.484 ms] -
appsec 2.4 ms [2.35 ms, 2.449 ms] 926.792 µs (62.9%)
iast 2.183 ms [2.122 ms, 2.245 ms] 710.347 µs (48.2%)
iast_GLOBAL 2.227 ms [2.165 ms, 2.289 ms] 754.068 µs (51.2%)
profiling 2.026 ms [1.977 ms, 2.076 ms] 553.317 µs (37.6%)
tracing 2.008 ms [1.96 ms, 2.056 ms] 535.467 µs (36.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~1191be52bd, baseline=1.50.0-SNAPSHOT~7787af738f
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.447 s) : 15447000, 15447000
.   : milestone, 15447000,
appsec (14.68 s) : 14680000, 14680000
.   : milestone, 14680000,
iast (19.123 s) : 19123000, 19123000
.   : milestone, 19123000,
iast_GLOBAL (18.022 s) : 18022000, 18022000
.   : milestone, 18022000,
profiling (15.231 s) : 15231000, 15231000
.   : milestone, 15231000,
tracing (14.92 s) : 14920000, 14920000
.   : milestone, 14920000,
section candidate
no_agent (15.534 s) : 15534000, 15534000
.   : milestone, 15534000,
appsec (14.703 s) : 14703000, 14703000
.   : milestone, 14703000,
iast (18.31 s) : 18310000, 18310000
.   : milestone, 18310000,
iast_GLOBAL (17.981 s) : 17981000, 17981000
.   : milestone, 17981000,
profiling (15.38 s) : 15380000, 15380000
.   : milestone, 15380000,
tracing (15.056 s) : 15056000, 15056000
.   : milestone, 15056000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.447 s [15.447 s, 15.447 s] -
appsec 14.68 s [14.68 s, 14.68 s] -767.0 ms (-5.0%)
iast 19.123 s [19.123 s, 19.123 s] 3.676 s (23.8%)
iast_GLOBAL 18.022 s [18.022 s, 18.022 s] 2.575 s (16.7%)
profiling 15.231 s [15.231 s, 15.231 s] -216.0 ms (-1.4%)
tracing 14.92 s [14.92 s, 14.92 s] -527.0 ms (-3.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.534 s [15.534 s, 15.534 s] -
appsec 14.703 s [14.703 s, 14.703 s] -831.0 ms (-5.3%)
iast 18.31 s [18.31 s, 18.31 s] 2.776 s (17.9%)
iast_GLOBAL 17.981 s [17.981 s, 17.981 s] 2.447 s (15.8%)
profiling 15.38 s [15.38 s, 15.38 s] -154.0 ms (-1.0%)
tracing 15.056 s [15.056 s, 15.056 s] -478.0 ms (-3.1%)

amarziali
amarziali reviewed Jun 5, 2025
View reviewed changes
internal-api/src/main/java/datadog/trace/api/Config.java
@@ -631,7 +631,8 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
serviceNameSetByUser = false;
serviceName = configProvider.getString(SERVICE, DEFAULT_SERVICE_NAME, SERVICE_NAME);
} else {
serviceNameSetByUser = true;
// might be an auto-detected name propagated from instrumented parent process
serviceNameSetByUser = configProvider.getBoolean(SERVICE_NAME_SET_BY_USER, true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this has been parametrized with a config flag? This flag is controlling few mechanisms on the service naming and I'm not sure that should modified in this way. If the parent process propagates DD_SERVICE that flag will be set to true as expected. Would that fix have just worked without changing that?

auto-merge was automatically disabled June 5, 2025 13:49

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali left review comments

@daniel-mohedano daniel-mohedano daniel-mohedano approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/ci-app-libraries-java

@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
comp: ci visibility Continuous Integration Visibility type: bug Bug report and fix
Projects
None yet
Milestone
1.49.1
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-tkachenko-datadog @amarziali @daniel-mohedano