Skip to content

Conversation

bric3
Copy link
Contributor

@bric3 bric3 commented Jun 13, 2025

What Does This Do

Avoids

Exception in thread "main" java.io.IOException: Server returned HTTP response code: 429 for URL: https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.6.3/apache-maven-3.6.3-bin.zip
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConnection.java:1917)
	at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1515)
	at sun.net.www.protocol.https.HttpsURLConnectionImpl.getInputStream(HttpsURLConnectionImpl.java:268)
	at org.apache.maven.wrapper.DefaultDownloader.downloadInternal(DefaultDownloader.java:90)
	at org.apache.maven.wrapper.DefaultDownloader.download(DefaultDownloader.java:76)
	at org.apache.maven.wrapper.Installer.createDist(Installer.java:72)
	at org.apache.maven.wrapper.WrapperExecutor.execute(WrapperExecutor.java:121)
	at org.apache.maven.wrapper.MavenWrapperMain.main(MavenWrapperMain.java:61)

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 13, 2025
@bric3 bric3 marked this pull request as ready for review June 13, 2025 15:47
@bric3 bric3 requested a review from a team as a code owner June 13, 2025 15:47
@bric3 bric3 requested review from TonyCTHsu and removed request for a team June 13, 2025 15:47
@pr-commenter
Copy link

pr-commenter bot commented Jun 13, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master additional-maven-proxy-fixes
git_commit_date 1749821757 1749832637
git_commit_sha ff2b2e9 381b600
release_version 1.50.0-SNAPSHOT~ff2b2e9415 1.50.0-SNAPSHOT~381b60057b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1749834824 1749834824
ci_job_id 981534887 981534887
ci_pipeline_id 67705287 67705287
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-fldqsnps-project-304-concurrent-0-tnqimyzi 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-fldqsnps-project-304-concurrent-0-tnqimyzi 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 13 unstable metrics.

Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~381b60057b, baseline=1.50.0-SNAPSHOT~ff2b2e9415

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.023 s) : 0, 1022568
Total [baseline] (8.52 s) : 0, 8520387
Agent [candidate] (1.022 s) : 0, 1021593
Total [candidate] (8.553 s) : 0, 8553337
section iast
Agent [baseline] (1.157 s) : 0, 1157302
Total [baseline] (9.199 s) : 0, 9198833
Agent [candidate] (1.161 s) : 0, 1160872
Total [candidate] (9.199 s) : 0, 9198983
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.15 s) : 0, 1149519
Total [baseline] (9.178 s) : 0, 9178470
Agent [candidate] (1.151 s) : 0, 1150791
Total [candidate] (9.17 s) : 0, 9170252
section iast_TELEMETRY_OFF
Agent [baseline] (1.147 s) : 0, 1146959
Total [baseline] (9.244 s) : 0, 9243594
Agent [candidate] (1.147 s) : 0, 1147106
Total [candidate] (9.23 s) : 0, 9229622
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent iast 1.157 s 134.735 ms (13.2%)
Agent iast_HARDCODED_SECRET_DISABLED 1.15 s 126.951 ms (12.4%)
Agent iast_TELEMETRY_OFF 1.147 s 124.392 ms (12.2%)
Total tracing 8.52 s -
Total iast 9.199 s 678.446 ms (8.0%)
Total iast_HARDCODED_SECRET_DISABLED 9.178 s 658.083 ms (7.7%)
Total iast_TELEMETRY_OFF 9.244 s 723.208 ms (8.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.022 s -
Agent iast 1.161 s 139.279 ms (13.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.151 s 129.197 ms (12.6%)
Agent iast_TELEMETRY_OFF 1.147 s 125.513 ms (12.3%)
Total tracing 8.553 s -
Total iast 9.199 s 645.647 ms (7.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.17 s 616.915 ms (7.2%)
Total iast_TELEMETRY_OFF 9.23 s 676.285 ms (7.9%)
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~381b60057b, baseline=1.50.0-SNAPSHOT~ff2b2e9415

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.908 ms) : 0, 682908
BytebuddyAgent [candidate] (682.503 ms) : 0, 682503
GlobalTracer [baseline] (239.579 ms) : 0, 239579
GlobalTracer [candidate] (240.349 ms) : 0, 240349
AppSec [baseline] (58.395 ms) : 0, 58395
AppSec [candidate] (57.003 ms) : 0, 57003
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (6.166 ms) : 0, 6166
Remote Config [baseline] (715.869 µs) : 0, 716
Remote Config [candidate] (738.877 µs) : 0, 739
Telemetry [baseline] (11.243 ms) : 0, 11243
Telemetry [candidate] (11.28 ms) : 0, 11280
section iast
BytebuddyAgent [baseline] (807.981 ms) : 0, 807981
BytebuddyAgent [candidate] (810.018 ms) : 0, 810018
GlobalTracer [baseline] (231.612 ms) : 0, 231612
GlobalTracer [candidate] (232.872 ms) : 0, 232872
IAST [baseline] (26.208 ms) : 0, 26208
IAST [candidate] (27.064 ms) : 0, 27064
AppSec [baseline] (53.397 ms) : 0, 53397
AppSec [candidate] (52.63 ms) : 0, 52630
Debugger [baseline] (5.995 ms) : 0, 5995
Debugger [candidate] (5.978 ms) : 0, 5978
Remote Config [baseline] (607.587 µs) : 0, 608
Remote Config [candidate] (603.58 µs) : 0, 604
Telemetry [baseline] (7.877 ms) : 0, 7877
Telemetry [candidate] (8.003 ms) : 0, 8003
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (802.211 ms) : 0, 802211
BytebuddyAgent [candidate] (801.875 ms) : 0, 801875
GlobalTracer [baseline] (229.904 ms) : 0, 229904
GlobalTracer [candidate] (230.584 ms) : 0, 230584
IAST [baseline] (27.688 ms) : 0, 27688
IAST [candidate] (27.213 ms) : 0, 27213
AppSec [baseline] (51.758 ms) : 0, 51758
AppSec [candidate] (53.104 ms) : 0, 53104
Debugger [baseline] (5.891 ms) : 0, 5891
Debugger [candidate] (5.958 ms) : 0, 5958
Remote Config [baseline] (584.865 µs) : 0, 585
Remote Config [candidate] (599.256 µs) : 0, 599
Telemetry [baseline] (7.942 ms) : 0, 7942
Telemetry [candidate] (7.908 ms) : 0, 7908
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (798.983 ms) : 0, 798983
BytebuddyAgent [candidate] (798.991 ms) : 0, 798991
GlobalTracer [baseline] (231.054 ms) : 0, 231054
GlobalTracer [candidate] (231.316 ms) : 0, 231316
IAST [baseline] (29.716 ms) : 0, 29716
IAST [candidate] (28.701 ms) : 0, 28701
AppSec [baseline] (49.348 ms) : 0, 49348
AppSec [candidate] (50.165 ms) : 0, 50165
Debugger [baseline] (5.947 ms) : 0, 5947
Debugger [candidate] (5.988 ms) : 0, 5988
Remote Config [baseline] (595.984 µs) : 0, 596
Remote Config [candidate] (594.945 µs) : 0, 595
Telemetry [baseline] (7.841 ms) : 0, 7841
Telemetry [candidate] (7.902 ms) : 0, 7902
Loading
Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~381b60057b, baseline=1.50.0-SNAPSHOT~ff2b2e9415

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.025 s) : 0, 1024862
Total [baseline] (10.474 s) : 0, 10473579
Agent [candidate] (1.029 s) : 0, 1028795
Total [candidate] (10.538 s) : 0, 10538000
section appsec
Agent [baseline] (1.179 s) : 0, 1179459
Total [baseline] (10.688 s) : 0, 10687801
Agent [candidate] (1.173 s) : 0, 1173161
Total [candidate] (10.665 s) : 0, 10664744
section iast
Agent [baseline] (1.15 s) : 0, 1149720
Total [baseline] (10.82 s) : 0, 10819873
Agent [candidate] (1.151 s) : 0, 1151091
Total [candidate] (10.906 s) : 0, 10906122
section profiling
Agent [baseline] (1.268 s) : 0, 1267995
Total [baseline] (10.934 s) : 0, 10933520
Agent [candidate] (1.267 s) : 0, 1267220
Total [candidate] (10.85 s) : 0, 10849791
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.025 s -
Agent appsec 1.179 s 154.597 ms (15.1%)
Agent iast 1.15 s 124.858 ms (12.2%)
Agent profiling 1.268 s 243.133 ms (23.7%)
Total tracing 10.474 s -
Total appsec 10.688 s 214.222 ms (2.0%)
Total iast 10.82 s 346.294 ms (3.3%)
Total profiling 10.934 s 459.941 ms (4.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.029 s -
Agent appsec 1.173 s 144.367 ms (14.0%)
Agent iast 1.151 s 122.296 ms (11.9%)
Agent profiling 1.267 s 238.425 ms (23.2%)
Total tracing 10.538 s -
Total appsec 10.665 s 126.744 ms (1.2%)
Total iast 10.906 s 368.122 ms (3.5%)
Total profiling 10.85 s 311.791 ms (3.0%)
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~381b60057b, baseline=1.50.0-SNAPSHOT~ff2b2e9415

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.491 ms) : 0, 684491
BytebuddyAgent [candidate] (686.981 ms) : 0, 686981
GlobalTracer [baseline] (240.666 ms) : 0, 240666
GlobalTracer [candidate] (241.67 ms) : 0, 241670
AppSec [baseline] (57.144 ms) : 0, 57144
AppSec [candidate] (58.096 ms) : 0, 58096
Debugger [baseline] (6.143 ms) : 0, 6143
Debugger [candidate] (6.23 ms) : 0, 6230
Remote Config [baseline] (730.39 µs) : 0, 730
Remote Config [candidate] (738.636 µs) : 0, 739
Telemetry [baseline] (12.111 ms) : 0, 12111
Telemetry [candidate] (11.321 ms) : 0, 11321
section appsec
BytebuddyAgent [baseline] (708.428 ms) : 0, 708428
BytebuddyAgent [candidate] (703.875 ms) : 0, 703875
GlobalTracer [baseline] (235.9 ms) : 0, 235900
GlobalTracer [candidate] (234.424 ms) : 0, 234424
AppSec [baseline] (175.759 ms) : 0, 175759
AppSec [candidate] (175.751 ms) : 0, 175751
Debugger [baseline] (5.941 ms) : 0, 5941
Debugger [candidate] (5.91 ms) : 0, 5910
Remote Config [baseline] (625.598 µs) : 0, 626
Remote Config [candidate] (609.832 µs) : 0, 610
Telemetry [baseline] (7.267 ms) : 0, 7267
Telemetry [candidate] (7.291 ms) : 0, 7291
IAST [baseline] (21.956 ms) : 0, 21956
IAST [candidate] (21.875 ms) : 0, 21875
section iast
BytebuddyAgent [baseline] (801.878 ms) : 0, 801878
BytebuddyAgent [candidate] (802.501 ms) : 0, 802501
GlobalTracer [baseline] (230.596 ms) : 0, 230596
GlobalTracer [candidate] (231.154 ms) : 0, 231154
AppSec [baseline] (52.417 ms) : 0, 52417
AppSec [candidate] (51.672 ms) : 0, 51672
Debugger [baseline] (5.918 ms) : 0, 5918
Debugger [candidate] (5.944 ms) : 0, 5944
Remote Config [baseline] (588.214 µs) : 0, 588
Remote Config [candidate] (615.3 µs) : 0, 615
Telemetry [baseline] (7.917 ms) : 0, 7917
Telemetry [candidate] (8.031 ms) : 0, 8031
IAST [baseline] (26.843 ms) : 0, 26843
IAST [candidate] (27.625 ms) : 0, 27625
section profiling
BytebuddyAgent [baseline] (676.897 ms) : 0, 676897
BytebuddyAgent [candidate] (676.172 ms) : 0, 676172
GlobalTracer [baseline] (360.313 ms) : 0, 360313
GlobalTracer [candidate] (360.271 ms) : 0, 360271
AppSec [baseline] (61.989 ms) : 0, 61989
AppSec [candidate] (61.975 ms) : 0, 61975
Debugger [baseline] (6.049 ms) : 0, 6049
Debugger [candidate] (6.118 ms) : 0, 6118
Remote Config [baseline] (650.84 µs) : 0, 651
Remote Config [candidate] (650.79 µs) : 0, 651
Telemetry [baseline] (8.097 ms) : 0, 8097
Telemetry [candidate] (8.068 ms) : 0, 8068
ProfilingAgent [baseline] (103.202 ms) : 0, 103202
ProfilingAgent [candidate] (103.136 ms) : 0, 103136
Profiling [baseline] (103.226 ms) : 0, 103226
Profiling [candidate] (103.16 ms) : 0, 103160
Loading

Load

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master additional-maven-proxy-fixes
git_commit_date 1749821757 1749832637
git_commit_sha ff2b2e9 381b600
release_version 1.50.0-SNAPSHOT~ff2b2e9415 1.50.0-SNAPSHOT~381b60057b
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1749834637 1749834637
ci_job_id 981534890 981534890
ci_pipeline_id 67705287 67705287
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-4zjsuzkc-project-304-concurrent-0-j9chllou 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-4zjsuzkc-project-304-concurrent-0-j9chllou 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~381b60057b, baseline=1.50.0-SNAPSHOT~ff2b2e9415
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
.   : milestone, 1477,
appsec (2.402 ms) : 2354, 2451
.   : milestone, 2402,
iast (2.193 ms) : 2132, 2254
.   : milestone, 2193,
iast_GLOBAL (2.232 ms) : 2171, 2294
.   : milestone, 2232,
profiling (2.496 ms) : 2320, 2672
.   : milestone, 2496,
tracing (2.01 ms) : 1962, 2057
.   : milestone, 2010,
section candidate
no_agent (1.476 ms) : 1465, 1488
.   : milestone, 1476,
appsec (2.416 ms) : 2367, 2466
.   : milestone, 2416,
iast (2.182 ms) : 2120, 2243
.   : milestone, 2182,
iast_GLOBAL (2.227 ms) : 2166, 2289
.   : milestone, 2227,
profiling (2.027 ms) : 1979, 2076
.   : milestone, 2027,
tracing (2.009 ms) : 1961, 2056
.   : milestone, 2009,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.477 ms [1.466 ms, 1.489 ms] -
appsec 2.402 ms [2.354 ms, 2.451 ms] 925.353 µs (62.6%)
iast 2.193 ms [2.132 ms, 2.254 ms] 715.508 µs (48.4%)
iast_GLOBAL 2.232 ms [2.171 ms, 2.294 ms] 755.153 µs (51.1%)
profiling 2.496 ms [2.32 ms, 2.672 ms] 1.019 ms (69.0%)
tracing 2.01 ms [1.962 ms, 2.057 ms] 532.621 µs (36.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.476 ms [1.465 ms, 1.488 ms] -
appsec 2.416 ms [2.367 ms, 2.466 ms] 939.922 µs (63.7%)
iast 2.182 ms [2.12 ms, 2.243 ms] 705.122 µs (47.8%)
iast_GLOBAL 2.227 ms [2.166 ms, 2.289 ms] 750.96 µs (50.9%)
profiling 2.027 ms [1.979 ms, 2.076 ms] 551.041 µs (37.3%)
tracing 2.009 ms [1.961 ms, 2.056 ms] 532.2 µs (36.0%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~381b60057b, baseline=1.50.0-SNAPSHOT~ff2b2e9415
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.523 s) : 15523000, 15523000
.   : milestone, 15523000,
appsec (14.766 s) : 14766000, 14766000
.   : milestone, 14766000,
iast (18.449 s) : 18449000, 18449000
.   : milestone, 18449000,
iast_GLOBAL (17.979 s) : 17979000, 17979000
.   : milestone, 17979000,
profiling (15.07 s) : 15070000, 15070000
.   : milestone, 15070000,
tracing (14.76 s) : 14760000, 14760000
.   : milestone, 14760000,
section candidate
no_agent (15.546 s) : 15546000, 15546000
.   : milestone, 15546000,
appsec (14.874 s) : 14874000, 14874000
.   : milestone, 14874000,
iast (18.807 s) : 18807000, 18807000
.   : milestone, 18807000,
iast_GLOBAL (17.949 s) : 17949000, 17949000
.   : milestone, 17949000,
profiling (15.076 s) : 15076000, 15076000
.   : milestone, 15076000,
tracing (14.91 s) : 14910000, 14910000
.   : milestone, 14910000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.523 s [15.523 s, 15.523 s] -
appsec 14.766 s [14.766 s, 14.766 s] -757.0 ms (-4.9%)
iast 18.449 s [18.449 s, 18.449 s] 2.926 s (18.8%)
iast_GLOBAL 17.979 s [17.979 s, 17.979 s] 2.456 s (15.8%)
profiling 15.07 s [15.07 s, 15.07 s] -453.0 ms (-2.9%)
tracing 14.76 s [14.76 s, 14.76 s] -763.0 ms (-4.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.546 s [15.546 s, 15.546 s] -
appsec 14.874 s [14.874 s, 14.874 s] -672.0 ms (-4.3%)
iast 18.807 s [18.807 s, 18.807 s] 3.261 s (21.0%)
iast_GLOBAL 17.949 s [17.949 s, 17.949 s] 2.403 s (15.5%)
profiling 15.076 s [15.076 s, 15.076 s] -470.0 ms (-3.0%)
tracing 14.91 s [14.91 s, 14.91 s] -636.0 ms (-4.1%)

@bric3 bric3 force-pushed the additional-maven-proxy-fixes branch from eca9f43 to 1a8a25d Compare June 13, 2025 15:55
@bric3 bric3 force-pushed the additional-maven-proxy-fixes branch from 1a8a25d to 381b600 Compare June 13, 2025 16:37
@bric3
Copy link
Contributor Author

bric3 commented Jun 13, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025

View all feedbacks in Devflow UI.

2025-06-13 16:45:33 UTC ℹ️ Start processing command /merge


2025-06-13 16:45:42 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-06-13 18:03:27 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@dd-devflow
Copy link

dd-devflow bot commented Jun 13, 2025

View all feedbacks in Devflow UI.

2025-06-13 18:03:17 UTC ℹ️ Start processing command /remove


2025-06-13 18:03:23 UTC ℹ️ Devflow: /remove

@mcculls mcculls merged commit 42c66c7 into master Jun 13, 2025
481 of 487 checks passed
@mcculls mcculls deleted the additional-maven-proxy-fixes branch June 13, 2025 18:10
@github-actions github-actions bot added this to the 1.50.0 milestone Jun 13, 2025
@PerfectSlayer PerfectSlayer changed the title additional-maven-proxy-fixes Fix rate limit with Maven wrapper downloads Jun 14, 2025
@PerfectSlayer PerfectSlayer added the type: bug Bug report and fix label Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes type: bug Bug report and fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants