Fix flaky out of order comparison for http client test #9158

amarziali · 2025-07-11T09:31:48Z

What Does This Do

Apache http client tests are quite flaky. Especially those couple with parent and errors.
This PR just try to remove the flakiness by sorting the spans by start in order to make the assertions reliable

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-07-11T10:05:09Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/httpclient5
git_commit_date	1752173281	1752226194
git_commit_sha	`ad6d6b9`	`88a7bbb`
release_version	1.52.0-SNAPSHOT~ad6d6b9786	1.52.0-SNAPSHOT~88a7bbba8b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1752228031	1752228031
ci_job_id	1024604853	1024604853
ci_pipeline_id	70279400	70279400
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-7sxb8ayn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-7sxb8ayn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~88a7bbba8b, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (994.681 ms) : 0, 994681
Total [baseline] (10.645 s) : 0, 10644774
Agent [candidate] (1.001 s) : 0, 1001418
Total [candidate] (10.693 s) : 0, 10693095
section appsec
Agent [baseline] (1.181 s) : 0, 1181009
Total [baseline] (10.767 s) : 0, 10767428
Agent [candidate] (1.186 s) : 0, 1186399
Total [candidate] (10.759 s) : 0, 10758633
section iast
Agent [baseline] (1.135 s) : 0, 1135288
Total [baseline] (10.895 s) : 0, 10895093
Agent [candidate] (1.137 s) : 0, 1136654
Total [candidate] (10.881 s) : 0, 10881130
section profiling
Agent [baseline] (1.27 s) : 0, 1269613
Total [baseline] (11.037 s) : 0, 11037423
Agent [candidate] (1.243 s) : 0, 1242918
Total [candidate] (10.977 s) : 0, 10977351

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	994.681 ms	-
Agent	appsec	1.181 s	186.328 ms (18.7%)
Agent	iast	1.135 s	140.607 ms (14.1%)
Agent	profiling	1.27 s	274.932 ms (27.6%)
Total	tracing	10.645 s	-
Total	appsec	10.767 s	122.653 ms (1.2%)
Total	iast	10.895 s	250.319 ms (2.4%)
Total	profiling	11.037 s	392.648 ms (3.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.001 s	-
Agent	appsec	1.186 s	184.981 ms (18.5%)
Agent	iast	1.137 s	135.236 ms (13.5%)
Agent	profiling	1.243 s	241.5 ms (24.1%)
Total	tracing	10.693 s	-
Total	appsec	10.759 s	65.538 ms (0.6%)
Total	iast	10.881 s	188.035 ms (1.8%)
Total	profiling	10.977 s	284.256 ms (2.7%)

gantt
    title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~88a7bbba8b, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (686.62 ms) : 0, 686620
BytebuddyAgent [candidate] (691.715 ms) : 0, 691715
GlobalTracer [baseline] (242.271 ms) : 0, 242271
GlobalTracer [candidate] (243.592 ms) : 0, 243592
AppSec [baseline] (30.157 ms) : 0, 30157
AppSec [candidate] (30.317 ms) : 0, 30317
Debugger [baseline] (5.962 ms) : 0, 5962
Debugger [candidate] (6.015 ms) : 0, 6015
Remote Config [baseline] (677.899 µs) : 0, 678
Remote Config [candidate] (674.292 µs) : 0, 674
Telemetry [baseline] (8.175 ms) : 0, 8175
Telemetry [candidate] (8.257 ms) : 0, 8257
section appsec
BytebuddyAgent [baseline] (714.369 ms) : 0, 714369
BytebuddyAgent [candidate] (717.865 ms) : 0, 717865
GlobalTracer [baseline] (236.336 ms) : 0, 236336
GlobalTracer [candidate] (237.025 ms) : 0, 237025
IAST [baseline] (23.763 ms) : 0, 23763
IAST [candidate] (23.941 ms) : 0, 23941
AppSec [baseline] (171.215 ms) : 0, 171215
AppSec [candidate] (172.018 ms) : 0, 172018
Debugger [baseline] (5.709 ms) : 0, 5709
Debugger [candidate] (5.711 ms) : 0, 5711
Remote Config [baseline] (602.942 µs) : 0, 603
Remote Config [candidate] (612.106 µs) : 0, 612
Telemetry [baseline] (8.034 ms) : 0, 8034
Telemetry [candidate] (8.051 ms) : 0, 8051
section iast
BytebuddyAgent [baseline] (809.045 ms) : 0, 809045
BytebuddyAgent [candidate] (810.229 ms) : 0, 810229
GlobalTracer [baseline] (232.95 ms) : 0, 232950
GlobalTracer [candidate] (233.216 ms) : 0, 233216
IAST [baseline] (26.656 ms) : 0, 26656
IAST [candidate] (25.718 ms) : 0, 25718
AppSec [baseline] (31.383 ms) : 0, 31383
AppSec [candidate] (31.381 ms) : 0, 31381
Debugger [baseline] (5.776 ms) : 0, 5776
Debugger [candidate] (6.714 ms) : 0, 6714
Remote Config [baseline] (592.421 µs) : 0, 592
Remote Config [candidate] (591.399 µs) : 0, 591
Telemetry [baseline] (8.016 ms) : 0, 8016
Telemetry [candidate] (7.983 ms) : 0, 7983
section profiling
BytebuddyAgent [baseline] (691.979 ms) : 0, 691979
BytebuddyAgent [candidate] (676.904 ms) : 0, 676904
GlobalTracer [baseline] (367.856 ms) : 0, 367856
GlobalTracer [candidate] (361.08 ms) : 0, 361080
AppSec [baseline] (33.889 ms) : 0, 33889
AppSec [candidate] (30.708 ms) : 0, 30708
Debugger [baseline] (9.829 ms) : 0, 9829
Debugger [candidate] (13.745 ms) : 0, 13745
Remote Config [baseline] (673.736 µs) : 0, 674
Remote Config [candidate] (646.933 µs) : 0, 647
Telemetry [baseline] (9.649 ms) : 0, 9649
Telemetry [candidate] (7.918 ms) : 0, 7918
ProfilingAgent [baseline] (105.891 ms) : 0, 105891
ProfilingAgent [candidate] (103.302 ms) : 0, 103302
Profiling [baseline] (105.916 ms) : 0, 105916
Profiling [candidate] (103.327 ms) : 0, 103327

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~88a7bbba8b, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (995.236 ms) : 0, 995236
Total [baseline] (8.573 s) : 0, 8573084
Agent [candidate] (997.527 ms) : 0, 997527
Total [candidate] (8.577 s) : 0, 8577228
section iast
Agent [baseline] (1.139 s) : 0, 1139163
Total [baseline] (9.335 s) : 0, 9335387
Agent [candidate] (1.145 s) : 0, 1145302
Total [candidate] (9.341 s) : 0, 9341139

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	995.236 ms	-
Agent	iast	1.139 s	143.928 ms (14.5%)
Total	tracing	8.573 s	-
Total	iast	9.335 s	762.302 ms (8.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	997.527 ms	-
Agent	iast	1.145 s	147.775 ms (14.8%)
Total	tracing	8.577 s	-
Total	iast	9.341 s	763.911 ms (8.9%)

gantt
    title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~88a7bbba8b, baseline=1.52.0-SNAPSHOT~ad6d6b9786

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.532 ms) : 0, 687532
BytebuddyAgent [candidate] (688.352 ms) : 0, 688352
GlobalTracer [baseline] (241.937 ms) : 0, 241937
GlobalTracer [candidate] (243.049 ms) : 0, 243049
AppSec [baseline] (30.12 ms) : 0, 30120
AppSec [candidate] (30.366 ms) : 0, 30366
Debugger [baseline] (5.997 ms) : 0, 5997
Debugger [candidate] (5.985 ms) : 0, 5985
Remote Config [baseline] (676.781 µs) : 0, 677
Remote Config [candidate] (691.028 µs) : 0, 691
Telemetry [baseline] (8.184 ms) : 0, 8184
Telemetry [candidate] (8.231 ms) : 0, 8231
section iast
BytebuddyAgent [baseline] (812.755 ms) : 0, 812755
BytebuddyAgent [candidate] (815.304 ms) : 0, 815304
GlobalTracer [baseline] (233.443 ms) : 0, 233443
GlobalTracer [candidate] (235.388 ms) : 0, 235388
IAST [baseline] (27.476 ms) : 0, 27476
IAST [candidate] (27.933 ms) : 0, 27933
AppSec [baseline] (29.537 ms) : 0, 29537
AppSec [candidate] (31.201 ms) : 0, 31201
Debugger [baseline] (5.755 ms) : 0, 5755
Debugger [candidate] (5.874 ms) : 0, 5874
Remote Config [baseline] (582.45 µs) : 0, 582
Remote Config [candidate] (602.953 µs) : 0, 603
Telemetry [baseline] (7.948 ms) : 0, 7948
Telemetry [candidate] (8.091 ms) : 0, 8091

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/httpclient5
git_commit_date	1752173281	1752226194
git_commit_sha	`ad6d6b9`	`88a7bbb`
release_version	1.52.0-SNAPSHOT~ad6d6b9786	1.52.0-SNAPSHOT~88a7bbba8b

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1752227714	1752227714
ci_job_id	1024604854	1024604854
ci_pipeline_id	70279400	70279400
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-iiy9gc23 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-iiy9gc23 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:petclinic:appsec:high_load	better [-2.129ms; -1.231ms] or [-4.538%; -2.624%]	unstable [-3.487op/s; +10.862op/s] or [-3.498%; +10.895%]	45.243ms	103.388op/s	46.924ms	99.700op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~88a7bbba8b, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.345 ms) : 4297, 4394
.   : milestone, 4345,
iast (9.361 ms) : 9200, 9523
.   : milestone, 9361,
iast_FULL (14.0 ms) : 13724, 14276
.   : milestone, 14000,
iast_GLOBAL (10.05 ms) : 9875, 10226
.   : milestone, 10050,
profiling (8.489 ms) : 8355, 8623
.   : milestone, 8489,
tracing (7.717 ms) : 7597, 7837
.   : milestone, 7717,
section candidate
no_agent (4.456 ms) : 4406, 4505
.   : milestone, 4456,
iast (9.715 ms) : 9551, 9878
.   : milestone, 9715,
iast_FULL (14.091 ms) : 13813, 14369
.   : milestone, 14091,
iast_GLOBAL (10.367 ms) : 10187, 10547
.   : milestone, 10367,
profiling (8.432 ms) : 8301, 8564
.   : milestone, 8432,
tracing (7.554 ms) : 7438, 7669
.   : milestone, 7554,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.345 ms [4.297 ms, 4.394 ms]	-
iast	9.361 ms [9.2 ms, 9.523 ms]	5.016 ms (115.4%)
iast_FULL	14.0 ms [13.724 ms, 14.276 ms]	9.655 ms (222.2%)
iast_GLOBAL	10.05 ms [9.875 ms, 10.226 ms]	5.705 ms (131.3%)
profiling	8.489 ms [8.355 ms, 8.623 ms]	4.143 ms (95.4%)
tracing	7.717 ms [7.597 ms, 7.837 ms]	3.372 ms (77.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.456 ms [4.406 ms, 4.505 ms]	-
iast	9.715 ms [9.551 ms, 9.878 ms]	5.259 ms (118.0%)
iast_FULL	14.091 ms [13.813 ms, 14.369 ms]	9.635 ms (216.3%)
iast_GLOBAL	10.367 ms [10.187 ms, 10.547 ms]	5.912 ms (132.7%)
profiling	8.432 ms [8.301 ms, 8.564 ms]	3.977 ms (89.3%)
tracing	7.554 ms [7.438 ms, 7.669 ms]	3.098 ms (69.5%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~88a7bbba8b, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.402 ms) : 36103, 36701
.   : milestone, 36402,
appsec (46.924 ms) : 46492, 47355
.   : milestone, 46924,
code_origins (45.532 ms) : 45142, 45922
.   : milestone, 45532,
iast (44.806 ms) : 44424, 45189
.   : milestone, 44806,
profiling (47.605 ms) : 47164, 48046
.   : milestone, 47605,
tracing (44.651 ms) : 44275, 45028
.   : milestone, 44651,
section candidate
no_agent (36.871 ms) : 36585, 37158
.   : milestone, 36871,
appsec (45.243 ms) : 44841, 45646
.   : milestone, 45243,
code_origins (44.219 ms) : 43845, 44592
.   : milestone, 44219,
iast (43.515 ms) : 43142, 43888
.   : milestone, 43515,
profiling (47.226 ms) : 46803, 47650
.   : milestone, 47226,
tracing (43.621 ms) : 43274, 43969
.   : milestone, 43621,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.402 ms [36.103 ms, 36.701 ms]	-
appsec	46.924 ms [46.492 ms, 47.355 ms]	10.521 ms (28.9%)
code_origins	45.532 ms [45.142 ms, 45.922 ms]	9.13 ms (25.1%)
iast	44.806 ms [44.424 ms, 45.189 ms]	8.404 ms (23.1%)
profiling	47.605 ms [47.164 ms, 48.046 ms]	11.203 ms (30.8%)
tracing	44.651 ms [44.275 ms, 45.028 ms]	8.249 ms (22.7%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.871 ms [36.585 ms, 37.158 ms]	-
appsec	45.243 ms [44.841 ms, 45.646 ms]	8.372 ms (22.7%)
code_origins	44.219 ms [43.845 ms, 44.592 ms]	7.347 ms (19.9%)
iast	43.515 ms [43.142 ms, 43.888 ms]	6.644 ms (18.0%)
profiling	47.226 ms [46.803 ms, 47.65 ms]	10.355 ms (28.1%)
tracing	43.621 ms [43.274 ms, 43.969 ms]	6.75 ms (18.3%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	andrea.marziali/httpclient5
git_commit_date	1752173281	1752226194
git_commit_sha	`ad6d6b9`	`88a7bbb`
release_version	1.52.0-SNAPSHOT~ad6d6b9786	1.52.0-SNAPSHOT~88a7bbba8b

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1752228228	1752228228
ci_job_id	1024604855	1024604855
ci_pipeline_id	70279400	70279400
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-dk1auot1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-dk1auot1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~88a7bbba8b, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.955 s) : 14955000, 14955000
.   : milestone, 14955000,
appsec (14.756 s) : 14756000, 14756000
.   : milestone, 14756000,
iast (18.151 s) : 18151000, 18151000
.   : milestone, 18151000,
iast_GLOBAL (18.181 s) : 18181000, 18181000
.   : milestone, 18181000,
profiling (15.112 s) : 15112000, 15112000
.   : milestone, 15112000,
tracing (14.803 s) : 14803000, 14803000
.   : milestone, 14803000,
section candidate
no_agent (15.252 s) : 15252000, 15252000
.   : milestone, 15252000,
appsec (14.736 s) : 14736000, 14736000
.   : milestone, 14736000,
iast (18.439 s) : 18439000, 18439000
.   : milestone, 18439000,
iast_GLOBAL (17.77 s) : 17770000, 17770000
.   : milestone, 17770000,
profiling (15.089 s) : 15089000, 15089000
.   : milestone, 15089000,
tracing (14.747 s) : 14747000, 14747000
.   : milestone, 14747000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.955 s [14.955 s, 14.955 s]	-
appsec	14.756 s [14.756 s, 14.756 s]	-199.0 ms (-1.3%)
iast	18.151 s [18.151 s, 18.151 s]	3.196 s (21.4%)
iast_GLOBAL	18.181 s [18.181 s, 18.181 s]	3.226 s (21.6%)
profiling	15.112 s [15.112 s, 15.112 s]	157.0 ms (1.0%)
tracing	14.803 s [14.803 s, 14.803 s]	-152.0 ms (-1.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.252 s [15.252 s, 15.252 s]	-
appsec	14.736 s [14.736 s, 14.736 s]	-516.0 ms (-3.4%)
iast	18.439 s [18.439 s, 18.439 s]	3.187 s (20.9%)
iast_GLOBAL	17.77 s [17.77 s, 17.77 s]	2.518 s (16.5%)
profiling	15.089 s [15.089 s, 15.089 s]	-163.0 ms (-1.1%)
tracing	14.747 s [14.747 s, 14.747 s]	-505.0 ms (-3.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~88a7bbba8b, baseline=1.52.0-SNAPSHOT~ad6d6b9786
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1491
.   : milestone, 1479,
appsec (2.424 ms) : 2373, 2474
.   : milestone, 2424,
iast (2.207 ms) : 2143, 2270
.   : milestone, 2207,
iast_GLOBAL (2.247 ms) : 2184, 2311
.   : milestone, 2247,
profiling (2.039 ms) : 1989, 2089
.   : milestone, 2039,
tracing (2.032 ms) : 1982, 2081
.   : milestone, 2032,
section candidate
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.415 ms) : 2365, 2465
.   : milestone, 2415,
iast (2.213 ms) : 2149, 2276
.   : milestone, 2213,
iast_GLOBAL (2.255 ms) : 2192, 2319
.   : milestone, 2255,
profiling (2.066 ms) : 2014, 2118
.   : milestone, 2066,
tracing (2.017 ms) : 1968, 2066
.   : milestone, 2017,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.479 ms [1.467 ms, 1.491 ms]	-
appsec	2.424 ms [2.373 ms, 2.474 ms]	944.696 µs (63.9%)
iast	2.207 ms [2.143 ms, 2.27 ms]	727.622 µs (49.2%)
iast_GLOBAL	2.247 ms [2.184 ms, 2.311 ms]	768.548 µs (52.0%)
profiling	2.039 ms [1.989 ms, 2.089 ms]	560.039 µs (37.9%)
tracing	2.032 ms [1.982 ms, 2.081 ms]	552.675 µs (37.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.467 ms, 1.49 ms]	-
appsec	2.415 ms [2.365 ms, 2.465 ms]	936.724 µs (63.4%)
iast	2.213 ms [2.149 ms, 2.276 ms]	734.288 µs (49.7%)
iast_GLOBAL	2.255 ms [2.192 ms, 2.319 ms]	777.055 µs (52.6%)
profiling	2.066 ms [2.014 ms, 2.118 ms]	587.425 µs (39.7%)
tracing	2.017 ms [1.968 ms, 2.066 ms]	538.515 µs (36.4%)

PerfectSlayer

Thanks for the fix

Fix flaky out of order comparison for http client test

88a7bbb

amarziali requested a review from a team as a code owner July 11, 2025 09:31

amarziali added type: enhancement Enhancements and improvements comp: testing Testing labels Jul 11, 2025

amarziali requested a review from smola July 11, 2025 09:31

amarziali added tag: no release notes Changes to exclude from release notes tag: flaky test Flaky tests labels Jul 11, 2025

amarziali enabled auto-merge (squash) July 11, 2025 09:33

PerfectSlayer approved these changes Jul 11, 2025

View reviewed changes

amarziali merged commit c949475 into master Jul 11, 2025
510 checks passed

amarziali deleted the andrea.marziali/httpclient5 branch July 11, 2025 12:10

github-actions bot added this to the 1.52.0 milestone Jul 11, 2025

mhlidd pushed a commit that referenced this pull request Jul 17, 2025

Fix flaky out of order comparison for http client test (#9158)

27d91ee

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix flaky out of order comparison for http client test #9158

Fix flaky out of order comparison for http client test #9158

Uh oh!

amarziali commented Jul 11, 2025

Uh oh!

pr-commenter bot commented Jul 11, 2025

Uh oh!

PerfectSlayer left a comment

Uh oh!

Uh oh!

Uh oh!

Fix flaky out of order comparison for http client test #9158

Fix flaky out of order comparison for http client test #9158

Uh oh!

Conversation

amarziali commented Jul 11, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter bot commented Jul 11, 2025

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!