-
Notifications
You must be signed in to change notification settings - Fork 312
Fix master failure after adding JDK 25 EA testing #9274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix master failure after adding JDK 25 EA testing #9274
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (331.167 µs) : 275, 387
. : milestone, 331,
basic (280.341 µs) : 274, 287
. : milestone, 280,
loop (8.97 ms) : 8964, 8975
. : milestone, 8970,
section candidate
noprobe (320.03 µs) : 291, 349
. : milestone, 320,
basic (276.899 µs) : 272, 282
. : milestone, 277,
loop (8.962 ms) : 8956, 8967
. : milestone, 8962,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.1-SNAPSHOT~e52dbc2514, baseline=1.51.1-SNAPSHOT~6860793509
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1049639
Total [baseline] (8.625 s) : 0, 8624741
Agent [candidate] (1.045 s) : 0, 1045417
Total [candidate] (8.58 s) : 0, 8580044
section iast
Agent [baseline] (1.173 s) : 0, 1173303
Total [baseline] (9.331 s) : 0, 9330668
Agent [candidate] (1.181 s) : 0, 1181340
Total [candidate] (9.34 s) : 0, 9340119
gantt
title insecure-bank - break down per module: candidate=1.51.1-SNAPSHOT~e52dbc2514, baseline=1.51.1-SNAPSHOT~6860793509
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.438 ms) : 0, 1438
BytebuddyAgent [baseline] (734.851 ms) : 0, 734851
BytebuddyAgent [candidate] (730.555 ms) : 0, 730555
GlobalTracer [baseline] (242.948 ms) : 0, 242948
GlobalTracer [candidate] (241.688 ms) : 0, 241688
AppSec [baseline] (30.577 ms) : 0, 30577
AppSec [candidate] (30.171 ms) : 0, 30171
Debugger [baseline] (6.069 ms) : 0, 6069
Debugger [candidate] (6.014 ms) : 0, 6014
Remote Config [baseline] (652.97 µs) : 0, 653
Remote Config [candidate] (641.875 µs) : 0, 642
Telemetry [baseline] (11.996 ms) : 0, 11996
Telemetry [candidate] (13.95 ms) : 0, 13950
section iast
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (846.581 ms) : 0, 846581
BytebuddyAgent [candidate] (854.109 ms) : 0, 854109
GlobalTracer [baseline] (230.817 ms) : 0, 230817
GlobalTracer [candidate] (231.848 ms) : 0, 231848
IAST [baseline] (28.382 ms) : 0, 28382
IAST [candidate] (28.993 ms) : 0, 28993
AppSec [baseline] (26.894 ms) : 0, 26894
AppSec [candidate] (27.523 ms) : 0, 27523
Debugger [baseline] (9.394 ms) : 0, 9394
Debugger [candidate] (7.521 ms) : 0, 7521
Remote Config [baseline] (602.543 µs) : 0, 603
Remote Config [candidate] (586.08 µs) : 0, 586
Telemetry [baseline] (8.18 ms) : 0, 8180
Telemetry [candidate] (8.089 ms) : 0, 8089
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.1-SNAPSHOT~e52dbc2514, baseline=1.51.1-SNAPSHOT~6860793509
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043894
Total [baseline] (10.704 s) : 0, 10703560
Agent [candidate] (1.043 s) : 0, 1042936
Total [candidate] (10.744 s) : 0, 10743742
section appsec
Agent [baseline] (1.218 s) : 0, 1217966
Total [baseline] (10.756 s) : 0, 10755533
Agent [candidate] (1.228 s) : 0, 1228449
Total [candidate] (10.769 s) : 0, 10768637
section iast
Agent [baseline] (1.186 s) : 0, 1185679
Total [baseline] (10.943 s) : 0, 10942546
Agent [candidate] (1.175 s) : 0, 1175457
Total [candidate] (10.914 s) : 0, 10914041
section profiling
Agent [baseline] (1.192 s) : 0, 1192035
Total [baseline] (10.841 s) : 0, 10841171
Agent [candidate] (1.198 s) : 0, 1198220
Total [candidate] (10.935 s) : 0, 10935136
gantt
title petclinic - break down per module: candidate=1.51.1-SNAPSHOT~e52dbc2514, baseline=1.51.1-SNAPSHOT~6860793509
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.429 ms) : 0, 1429
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (729.84 ms) : 0, 729840
BytebuddyAgent [candidate] (730.644 ms) : 0, 730644
GlobalTracer [baseline] (241.423 ms) : 0, 241423
GlobalTracer [candidate] (241.568 ms) : 0, 241568
AppSec [baseline] (30.263 ms) : 0, 30263
AppSec [candidate] (30.364 ms) : 0, 30364
Debugger [baseline] (5.993 ms) : 0, 5993
Debugger [candidate] (6.011 ms) : 0, 6011
Remote Config [baseline] (650.965 µs) : 0, 651
Remote Config [candidate] (657.226 µs) : 0, 657
Telemetry [baseline] (13.275 ms) : 0, 13275
Telemetry [candidate] (11.184 ms) : 0, 11184
section appsec
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (751.956 ms) : 0, 751956
BytebuddyAgent [candidate] (758.606 ms) : 0, 758606
GlobalTracer [baseline] (234.814 ms) : 0, 234814
GlobalTracer [candidate] (236.681 ms) : 0, 236681
AppSec [baseline] (169.178 ms) : 0, 169178
AppSec [candidate] (168.147 ms) : 0, 168147
Debugger [baseline] (7.162 ms) : 0, 7162
Debugger [candidate] (9.594 ms) : 0, 9594
Remote Config [baseline] (622.504 µs) : 0, 623
Remote Config [candidate] (617.723 µs) : 0, 618
Telemetry [baseline] (8.252 ms) : 0, 8252
Telemetry [candidate] (8.232 ms) : 0, 8232
IAST [baseline] (23.549 ms) : 0, 23549
IAST [candidate] (23.883 ms) : 0, 23883
section iast
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.433 ms) : 0, 1433
BytebuddyAgent [baseline] (856.374 ms) : 0, 856374
BytebuddyAgent [candidate] (847.867 ms) : 0, 847867
GlobalTracer [baseline] (233.193 ms) : 0, 233193
GlobalTracer [candidate] (231.989 ms) : 0, 231989
AppSec [baseline] (26.017 ms) : 0, 26017
AppSec [candidate] (26.645 ms) : 0, 26645
Debugger [baseline] (6.723 ms) : 0, 6723
Debugger [candidate] (7.638 ms) : 0, 7638
Remote Config [baseline] (605.414 µs) : 0, 605
Remote Config [candidate] (613.412 µs) : 0, 613
Telemetry [baseline] (8.155 ms) : 0, 8155
Telemetry [candidate] (8.215 ms) : 0, 8215
IAST [baseline] (31.957 ms) : 0, 31957
IAST [candidate] (30.028 ms) : 0, 30028
section profiling
ProfilingAgent [baseline] (108.401 ms) : 0, 108401
ProfilingAgent [candidate] (108.596 ms) : 0, 108596
crashtracking [baseline] (1.395 ms) : 0, 1395
crashtracking [candidate] (1.408 ms) : 0, 1408
BytebuddyAgent [baseline] (759.384 ms) : 0, 759384
BytebuddyAgent [candidate] (763.84 ms) : 0, 763840
GlobalTracer [baseline] (221.334 ms) : 0, 221334
GlobalTracer [candidate] (221.453 ms) : 0, 221453
AppSec [baseline] (30.127 ms) : 0, 30127
AppSec [candidate] (30.477 ms) : 0, 30477
Debugger [baseline] (6.271 ms) : 0, 6271
Debugger [candidate] (6.321 ms) : 0, 6321
Remote Config [baseline] (688.913 µs) : 0, 689
Remote Config [candidate] (701.87 µs) : 0, 702
Telemetry [baseline] (15.057 ms) : 0, 15057
Telemetry [candidate] (15.766 ms) : 0, 15766
Profiling [baseline] (109.024 ms) : 0, 109024
Profiling [candidate] (109.255 ms) : 0, 109255
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~e52dbc2514, baseline=1.51.1-SNAPSHOT~6860793509
dateFormat X
axisFormat %s
section baseline
no_agent (38.026 ms) : 37721, 38330
. : milestone, 38026,
appsec (48.585 ms) : 48155, 49016
. : milestone, 48585,
code_origins (45.214 ms) : 44825, 45603
. : milestone, 45214,
iast (45.599 ms) : 45176, 46022
. : milestone, 45599,
profiling (48.089 ms) : 47657, 48522
. : milestone, 48089,
tracing (42.578 ms) : 42204, 42952
. : milestone, 42578,
section candidate
no_agent (36.835 ms) : 36532, 37138
. : milestone, 36835,
appsec (46.2 ms) : 45799, 46600
. : milestone, 46200,
code_origins (45.301 ms) : 44937, 45666
. : milestone, 45301,
iast (44.117 ms) : 43719, 44516
. : milestone, 44117,
profiling (50.408 ms) : 49883, 50932
. : milestone, 50408,
tracing (43.459 ms) : 43088, 43830
. : milestone, 43459,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.1-SNAPSHOT~e52dbc2514, baseline=1.51.1-SNAPSHOT~6860793509
dateFormat X
axisFormat %s
section baseline
no_agent (4.369 ms) : 4315, 4422
. : milestone, 4369,
iast (9.438 ms) : 9286, 9591
. : milestone, 9438,
iast_FULL (13.495 ms) : 13230, 13761
. : milestone, 13495,
iast_GLOBAL (10.29 ms) : 10095, 10485
. : milestone, 10290,
profiling (9.107 ms) : 8965, 9248
. : milestone, 9107,
tracing (7.519 ms) : 7405, 7634
. : milestone, 7519,
section candidate
no_agent (4.44 ms) : 4383, 4497
. : milestone, 4440,
iast (9.421 ms) : 9262, 9580
. : milestone, 9421,
iast_FULL (14.127 ms) : 13846, 14408
. : milestone, 14127,
iast_GLOBAL (10.339 ms) : 10145, 10534
. : milestone, 10339,
profiling (8.85 ms) : 8698, 9002
. : milestone, 8850,
tracing (7.68 ms) : 7563, 7798
. : milestone, 7680,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~e52dbc2514, baseline=1.51.1-SNAPSHOT~6860793509
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (2.477 ms) : 2423, 2531
. : milestone, 2477,
iast (2.21 ms) : 2147, 2273
. : milestone, 2210,
iast_GLOBAL (2.248 ms) : 2185, 2311
. : milestone, 2248,
profiling (2.048 ms) : 1997, 2098
. : milestone, 2048,
tracing (2.015 ms) : 1967, 2064
. : milestone, 2015,
section candidate
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.653 ms) : 3434, 3871
. : milestone, 3653,
iast (2.204 ms) : 2141, 2267
. : milestone, 2204,
iast_GLOBAL (2.247 ms) : 2184, 2310
. : milestone, 2247,
profiling (2.042 ms) : 1992, 2092
. : milestone, 2042,
tracing (2.021 ms) : 1973, 2070
. : milestone, 2021,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.1-SNAPSHOT~e52dbc2514, baseline=1.51.1-SNAPSHOT~6860793509
dateFormat X
axisFormat %s
section baseline
no_agent (15.43 s) : 15430000, 15430000
. : milestone, 15430000,
appsec (14.731 s) : 14731000, 14731000
. : milestone, 14731000,
iast (18.477 s) : 18477000, 18477000
. : milestone, 18477000,
iast_GLOBAL (17.937 s) : 17937000, 17937000
. : milestone, 17937000,
profiling (15.311 s) : 15311000, 15311000
. : milestone, 15311000,
tracing (15.109 s) : 15109000, 15109000
. : milestone, 15109000,
section candidate
no_agent (15.52 s) : 15520000, 15520000
. : milestone, 15520000,
appsec (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
iast (18.635 s) : 18635000, 18635000
. : milestone, 18635000,
iast_GLOBAL (18.104 s) : 18104000, 18104000
. : milestone, 18104000,
profiling (15.743 s) : 15743000, 15743000
. : milestone, 15743000,
tracing (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
|
Signed-off-by: Nayeem Kamal <[email protected]>
What Does This Do
Kotlin compilation fails for JDK 25 EA and JDK 25 (unreleased). So, temporarily override the
java.version
to be the latest JDK general release24
until25
is GA-ed and tested.Motivation
Fix master
Additional Notes
Master failure: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/jobs/1053846178
Running
./gradlew :dd-java-agent:agent-debugger:test -PtestJvm=25
was failing but now passes locally.Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]