-
Notifications
You must be signed in to change notification settings - Fork 437
chore: fix broken conftests circle ci #10394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Datadog ReportBranch report: ✅ 0 Failed, 118996 Passed, 23772 Skipped, 3h 28m 15.37s Total duration (1m 43.35s time saved) |
romainkomorn-exdatadog
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10373 modified docker/Dockerfile but didn't trigger conftests circle ci test and merged. After the merge on main, conftests started to fail on main.
hatch.toml
. This actually looks like a bug on hatch and for now setting the version to be 3.10 as circle ci docker image we use for conftests is based on python 3.10, and hatch seems to pick up the version when it's available. If not set, hatch installs 3.12 and results in this weird error, failing to install ddtrace as it can't find clang compiler.gen_circleci_config.py calls
fnmatch.filter(changed_files, pattern)
to get the list of files matching pattern and look below.Checklist
Reviewer Checklist