Skip to content

chore: fix broken conftests circle ci #10394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Conversation

taegyunkim
Copy link
Contributor

@taegyunkim taegyunkim commented Aug 27, 2024

#10373 modified docker/Dockerfile but didn't trigger conftests circle ci test and merged. After the merge on main, conftests started to fail on main.

  1. Fix it by specifying the python version on hatch.toml. This actually looks like a bug on hatch and for now setting the version to be 3.10 as circle ci docker image we use for conftests is based on python 3.10, and hatch seems to pick up the version when it's available. If not set, hatch installs 3.12 and results in this weird error, failing to install ddtrace as it can't find clang compiler.
  2. Also updates suitespec generator
    gen_circleci_config.py calls fnmatch.filter(changed_files, pattern) to get the list of files matching pattern and look below.
❯ python
Python 3.12.5 (main, Aug 20 2024, 16:07:54) [GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import fnmatch
>>> fnmatch.filter(["docker/Dockerfile"], "docker")
[]
>>> fnmatch.filter(["docker/Dockerfile"], "docker*")
['docker/Dockerfile']

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Copy link
Contributor

github-actions bot commented Aug 27, 2024

CODEOWNERS have been resolved as:

hatch.toml                                                              @DataDog/python-guild
scripts/gen_circleci_config.py                                          @DataDog/apm-core-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Aug 27, 2024

Datadog Report

Branch report: taegyunkim/conftests
Commit report: 3058d17
Test service: dd-trace-py

✅ 0 Failed, 118996 Passed, 23772 Skipped, 3h 28m 15.37s Total duration (1m 43.35s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Aug 27, 2024

Benchmarks

Benchmark execution time: 2024-08-27 02:30:59

Comparing candidate commit 3058d17 in PR branch taegyunkim/conftests with baseline commit ecc5741 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

@taegyunkim taegyunkim changed the title change to trigger conftest chore: fix broken conftest circle ci Aug 27, 2024
@taegyunkim taegyunkim changed the title chore: fix broken conftest circle ci chore: fix broken conftests circle ci Aug 27, 2024
@taegyunkim taegyunkim added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2024
@taegyunkim taegyunkim marked this pull request as ready for review August 27, 2024 01:57
@taegyunkim taegyunkim requested review from a team as code owners August 27, 2024 01:57
@taegyunkim taegyunkim enabled auto-merge (squash) August 27, 2024 02:04
@romainkomorn-exdatadog romainkomorn-exdatadog merged commit 75a2376 into main Aug 27, 2024
205 of 207 checks passed
@romainkomorn-exdatadog romainkomorn-exdatadog deleted the taegyunkim/conftests branch August 27, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants