-
Notifications
You must be signed in to change notification settings - Fork 437
chore(iast): optimize modulo aspect more (3/3) #10514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
…optimize-operator-modulo-more
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
…o juanjux/optimize-as-formatted-evidence
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
…github.com:DataDog/dd-trace-py into juanjux/APPSEC-54648-optimize-operator-modulo-more
Signed-off-by: Juanjo Alvarez <[email protected]>
…o juanjux/optimize-as-formatted-evidence
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
…ormatted-evidence
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Datadog ReportBranch report: ❌ 245 Failed (0 Known Flaky), 1332 Passed, 756 Skipped, 7m 14.53s Total Time ❌ Failed Tests (245)
|
|
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
…ataDog/dd-trace-py into juanjux/optimize-as-formatted-evidence
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
Signed-off-by: Juanjo Alvarez <[email protected]>
…ataDog/dd-trace-py into juanjux/optimize-as-formatted-evidence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we're going to wait to 2.13 release candidate first
Description
Further optimize the native modulo aspect. This times we have a 8x performance improvement over the second part of this PR or a 16x performance improvement over the original version.
Also:
TRY_CATCH
macro now accepts the return value expression as a parameter.aspect_modulo
now operates onPyObject*
directly and uses CPython call mechanism (instead of PyBind11 one).as_formatted_evidence
now works withstd::string
to easy usage with aspects working withPyObject*
.[api_]as_formatted_evidence
now work withTaintRange
references.api_convert_escaped_text_to_tainted_text
working directly withPyObject*
.CMakeLists.txt
now fetches and links the ICU Unicode library.AnyTextObjectToString
,get_pytext_type
,StringToPyObject
,PyObjectToString
andPyObjectToPyText
.Checklist
Reviewer Checklist