-
Notifications
You must be signed in to change notification settings - Fork 439
chore(tracer): add type annotation for HttpPropagator extract #13331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 233 ± 4 ms. The average import time from base is: 238 ± 5 ms. The import time difference between this PR and base is: -4.5 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-05 18:22:08 Comparing candidate commit 0901e54 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 504 metrics, 5 unstable metrics. scenario:iast_aspects-format_map_aspect
scenario:iast_aspects-ospathdirname_aspect
scenario:telemetryaddmetric-1-distribution-metric-1-times
|
typing is failing: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-py/-/jobs/924198441. This points to a bug in the injection/extraction logic. We should make sure these methods never return |
Add type annotation for HTTPPropagator extract method.
For Issue: #12737
Checklist
Reviewer Checklist