-
Notifications
You must be signed in to change notification settings - Fork 439
fix(di): prevent exception when removing unresolved probe #13357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We prevent an exception from occurring when trying to remove a probe that did not resolve to a valid source code location.
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 232 ± 4 ms. The average import time from base is: 234 ± 4 ms. The import time difference between this PR and base is: -1.6 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
BenchmarksBenchmark execution time: 2025-05-08 10:01:43 Comparing candidate commit 16674f1 in PR branch Found 0 performance improvements and 6 performance regressions! Performance is the same for 523 metrics, 7 unstable metrics. scenario:iast_aspects-modulo_aspect_for_bytes
scenario:iast_aspects-modulo_aspect_for_bytes_bytearray
scenario:iast_aspects-replace_aspect
scenario:iast_aspects-rstrip_aspect
scenario:iast_aspects-strip_aspect
scenario:iast_aspects-swapcase_aspect
|
We prevent an exception from occurring when trying to remove a probe that did not resolve to a valid source code location. ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [ ] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit ebc7e4d)
We prevent an exception from occurring when trying to remove a probe that did not resolve to a valid source code location.
Checklist
Reviewer Checklist