-
Notifications
You must be signed in to change notification settings - Fork 455
chore(sampling): track knuth sampling in distributed trace #14425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 269 ± 3 ms. The average import time from base is: 276 ± 5 ms. The import time difference between this PR and base is: -6.9 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
ddtrace/internal/sampling.py
Outdated
span.set_metric(_SINGLE_SPAN_SAMPLING_RATE, self._sample_rate) | ||
span.set_metric(KNUTH_SAMPLE_RATE_KEY, self._sample_rate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have two tags for the exact same value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. We are planning to deprecate all sampling rate tags and replace it with dd.p.ksr
, I'll send you the planning doc
Performance SLOsCandidate: munir/track-sampling-ksr (8e4bc88) 🔵 No Baseline Data (24 suites)🔵 coreapiscenario - 12/12 (2 unstable)🔵 No baseline data available for this suite
|
Changes
_dd.p.ksr
tag to all sampled spans via single span, priority, and trace samplingMotivation
Checklist
Reviewer Checklist