tests: organize test helpers #1589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kyle-Verhoog
force-pushed
the
kylev/clean-up-helpers
branch
from
6ab6903 to
49e71c5
Compare
majorgreys
previously approved these changes
Aug 8, 2020
Kyle-Verhoog
force-pushed
the
kylev/clean-up-helpers
branch
from
5293b74 to
b394997
Compare
majorgreys
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a variety of helper classes and functions scattered all over the tests module. This patch consolidates them in the
testsmodule which makes it easy to find, modify and import them in all our test cases.Most of these changes are inspired/copied from the work done in #1558.
This PR is based off of #1581 and so is dependent on it. It also depends on #1588 since those tests depend on some unnecessary import assumptions.