fix(django): trace mro chain for Django views #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trace-py into brettlangdon/django.view.mro
brettlangdon
previously approved these changes
Aug 25, 2020
Kyle-Verhoog
force-pushed
the
brettlangdon/django.view.mro
branch
from
4be839e to
9f07022
Compare
brettlangdon
approved these changes
Aug 25, 2020
Kyle-Verhoog
added a commit
that referenced
this pull request
Aug 25, 2020
Kyle-Verhoog
added a commit
that referenced
this pull request
Aug 25, 2020
Kyle-Verhoog
added a commit
that referenced
this pull request
Aug 25, 2020
Kyle-Verhoog
added a commit
that referenced
this pull request
Aug 25, 2020
brettlangdon
pushed a commit
that referenced
this pull request
Aug 25, 2020
Kyle-Verhoog
added a commit
that referenced
this pull request
Aug 26, 2020
Kyle-Verhoog
added a commit
that referenced
this pull request
Aug 26, 2020
Kyle-Verhoog
added a commit
that referenced
this pull request
Aug 26, 2020
majorgreys
pushed a commit
that referenced
this pull request
Sep 10, 2020
5 tasks
Kyle-Verhoog
added a commit
that referenced
this pull request
Oct 23, 2020
We had been silently failing to instrument views for feed-view, partial-view and include because of a change introduced with #1625. Tracer debug logs do show this. This PR fixes the instrumentation code to check if the view has an mro before traversing it and fixes the tests by adding snapshot regressions. Co-authored-by: Kyle Verhoog <[email protected]> Co-authored-by: Kyle Verhoog <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.