Skip to content

fix(gevent): don't forget to call activate hooks on span activation (backport #2605) #2607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021
Merged

fix(gevent): don't forget to call activate hooks on span activation (backport #2605) #2607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ddtrace/contrib/gevent/provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def activate(self, context):
current_g = gevent.getcurrent()
if current_g is not None:
setattr(current_g, self._CONTEXT_ATTR, context)
super(GeventContextProvider, self).activate(context)
return context

def active(self):
Expand Down
15 changes: 15 additions & 0 deletions tests/contrib/gevent/test_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
from ddtrace.contrib.gevent import provider


def test_call_hooks(tracer):
data = {}

def record(context):
if "trace" not in data:
data["trace"] = context

tracer.configure(context_provider=provider.GeventContextProvider())
tracer.context_provider._on_activate(record)
with tracer.trace("test123") as mytrace:
pass
assert data["trace"] is mytrace