Skip to content

Conversation

P403n1x87
Copy link
Contributor

Description

This change fixes the handling of endpoint paths that take non-string arguments.

Fixes #2678.

Checklist

  • Added to the correct milestone.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Library documentation is updated.
  • Corp site documentation is updated (link to the PR).

This change fixes the handling of endpoint paths that take non-string
arguments.

Fixes DataDog#2678.
@P403n1x87 P403n1x87 requested a review from a team as a code owner July 27, 2021 11:09
nizox
nizox previously approved these changes Jul 27, 2021
Copy link
Contributor

@nizox nizox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM

@P403n1x87 P403n1x87 requested a review from nizox July 27, 2021 11:44
@mergify mergify bot merged commit c95322a into DataDog:master Jul 27, 2021
@Kyle-Verhoog
Copy link
Member

@Mergifyio backport 0.50

mergify bot pushed a commit that referenced this pull request Jul 28, 2021
* fix(sanic): fix handling of non-string arguments

This change fixes the handling of endpoint paths that take non-string
arguments.

Fixes #2678.

* Update ddtrace/contrib/sanic/patch.py

Co-authored-by: Nicolas Vivet <[email protected]>

Co-authored-by: Nicolas Vivet <[email protected]>
(cherry picked from commit c95322a)
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2021

Command backport 0.50: success

Backports have been created

mergify bot added a commit that referenced this pull request Jul 28, 2021
)

* fix(sanic): fix handling of non-string arguments (#2699)

* fix(sanic): fix handling of non-string arguments

This change fixes the handling of endpoint paths that take non-string
arguments.

Fixes #2678.

* Update ddtrace/contrib/sanic/patch.py

Co-authored-by: Nicolas Vivet <[email protected]>

Co-authored-by: Nicolas Vivet <[email protected]>
(cherry picked from commit c95322a)

* fix: fix latest sanic release note (#2703)

Co-authored-by: Gabriele N. Tornetta <[email protected]>
@Kyle-Verhoog Kyle-Verhoog added this to the 0.51.0 milestone Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.50 bug sanic APM
4 participants