fix(profiling): make sure lineno is always an int and funcname is never None #3099
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, f_lineno can be
None
which would trigger an error in the pprofoutput. This is not even caught by mypy, and I've proposed a fix here:
python/typeshed#6769
This patch makes sure we always use 0 if the line number is
None
.It also makes sure a funcname is always passed — in practice it's now the case,
but make sure typing reflects that.
Fixes #3046