Skip to content

ci: upgrade riot to fix dev packages [backport #5972 to 1.12] #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

mabdinur
Copy link
Contributor

Backport of #5972 to 1.12

Follow up to: #5949

We will need to merge this PR before typing_extensions v4.6.3 is released (link) or ci will be break again.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.

Follow up to: #5949

We will need to merge this PR before typing_extensions v4.6.3 is
released
([link](python/typing_extensions#196 (comment)))
or ci will be break again.

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.

---------

Co-authored-by: Gabriele N. Tornetta <[email protected]>
Co-authored-by: Gabriele N. Tornetta <[email protected]>
Co-authored-by: Brett Langdon <[email protected]>
(cherry picked from commit c0174f8)
@mabdinur mabdinur requested review from a team as code owners July 13, 2023 14:24
@mabdinur mabdinur requested a review from gnufede July 13, 2023 14:24
@mabdinur mabdinur added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 13, 2023
@mabdinur mabdinur requested a review from P403n1x87 July 13, 2023 14:24
@mabdinur mabdinur self-assigned this Jul 13, 2023
@mabdinur mabdinur enabled auto-merge (squash) July 13, 2023 14:24
@pr-commenter
Copy link

pr-commenter bot commented Jul 13, 2023

Benchmarks

Comparing candidate commit 4cc040e in PR branch backport-5972-to-1.12 with baseline commit 71a642b in branch 1.12.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 60 cases.

@mabdinur
Copy link
Contributor Author

The 1.12 branch is missing some backports 😞

@majorgreys majorgreys closed this Jul 13, 2023
auto-merge was automatically disabled July 13, 2023 18:00

Pull request was closed

@Yun-Kim Yun-Kim deleted the backport-5972-to-1.12 branch July 13, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants