Skip to content

refactor(profiling): patch for native ID if necessary #8870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Apr 4, 2024

We limit the wrapping of the thread bootstrapping logic to capture the native ID only on CPython 3.7, which is the only version of CPython that we support that has no thread native ID support.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.
  • If change touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@P403n1x87 P403n1x87 added changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling labels Apr 4, 2024
@P403n1x87 P403n1x87 self-assigned this Apr 4, 2024
@P403n1x87 P403n1x87 requested review from a team as code owners April 4, 2024 13:04
@P403n1x87 P403n1x87 requested a review from brettlangdon April 4, 2024 13:04
@P403n1x87 P403n1x87 enabled auto-merge (squash) April 4, 2024 13:04
@P403n1x87 P403n1x87 force-pushed the refactor/profiling-thread-native-id branch from 083f6e3 to 70a9ad5 Compare April 4, 2024 13:06
We limit the wrapping of the tread bootstrapping logic to capture the
native ID only on CPython 3.7, which is the only version of CPython that
we support that has no thread native ID support.
@P403n1x87 P403n1x87 force-pushed the refactor/profiling-thread-native-id branch from 70a9ad5 to 40b83ef Compare April 4, 2024 13:27
Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--thank you

Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests? or they don't need to change because this is effectively the same thing because of the hasattr() check?

@P403n1x87
Copy link
Contributor Author

tests? or they don't need to change because this is effectively the same thing because of the hasattr() check?

yep this should be functionally equivalent to the previous version of the code.

@P403n1x87 P403n1x87 merged commit 918aeba into DataDog:main Apr 4, 2024
@P403n1x87 P403n1x87 deleted the refactor/profiling-thread-native-id branch April 15, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants