Skip to content

Avoid example redefinition warning in test suite #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

p-datadog
Copy link
Member

@p-datadog p-datadog commented Apr 28, 2025

What does this PR do?

Refactors the examples to avoid this warning:

WARNING: Shared example group 'a binary setting with' has been previously defined at:
  /home/w/apps/dd-trace-rb/spec/datadog/core/configuration/settings_spec.rb:12
...and you are now defining it at:
  /home/w/apps/dd-trace-rb/spec/datadog/core/configuration/settings_spec.rb:12

Motivation:

Warning-clean test suite

Change log entry
None

Additional Notes:
N/A

How to test the change?
Tested manually by running the relevant examples:

rspec spec/datadog/core/configuration/settings_spec.rb spec/datadog/tracing/configuration/settings_spec.rb

@p-datadog p-datadog requested review from a team as code owners April 28, 2025 18:29
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Apr 28, 2025
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (b9e1364) to head (c389d79).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4612      +/-   ##
==========================================
- Coverage   97.74%   97.74%   -0.01%     
==========================================
  Files        1412     1413       +1     
  Lines       86256    86170      -86     
  Branches     4354     4357       +3     
==========================================
- Hits        84315    84224      -91     
- Misses       1941     1946       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Apr 28, 2025

Datadog Report

Branch report: avoid-example-redef
Commit report: c389d79
Test service: dd-trace-rb

✅ 0 Failed, 20987 Passed, 1376 Skipped, 3m 36.8s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Apr 28, 2025

Benchmarks

Benchmark execution time: 2025-04-29 12:29:23

Comparing candidate commit c389d79 in PR branch avoid-example-redef with baseline commit b9e1364 in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:tracing - 100 span trace - no writer

  • 🟩 throughput [+16.955op/s; +17.396op/s] or [+5.472%; +5.614%]

scenario:tracing - Propagation - Trace Context

  • 🟩 throughput [+3463.860op/s; +3560.266op/s] or [+10.275%; +10.561%]

Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants