Update README.md #20262
Open
Update README.md #20262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog Summary✅ Code Quality ✅ Code Security ❌ Dependencies Was this helpful? Give us feedback! |
brett0000FF
approved these changes
May 12, 2025
| @@ -369,6 +369,7 @@ To connect to Oracle through TCPS (TCP with SSL), uncomment the `protocol` confi | |||
|
|
|||
| ### Custom query | |||
|
|
|||
| Custom Query is used to get specific fields from the database to be used a custom metrics. | |||
There was a problem hiding this comment.
Suggested change
| Custom Query is used to get specific fields from the database to be used a custom metrics. | |
| Custom Query is used to extract specific fields from the database to be used as custom metrics. |
| @@ -377,6 +378,7 @@ Providing custom queries is also supported. Each query must have two parameters: | |||
| | `columns` | This is a list representing each column, ordered sequentially from left to right. There are two required pieces of data: <br> a. `type` - This is the submission method (`gauge`, `count`, etc.). <br> b. name - This is the suffix used to form the full metric name. If `type` is `tag`, this column is instead considered as a tag which is applied to every metric collected by this particular query. | | |||
|
|
|||
| Optionally use the `tags` parameter to apply a list of tags to each metric collected. | |||
| The **number of columns** Output from the Custom Query should be **equal to to number of metrics variables** in the conf.yaml file shown below. | |||
There was a problem hiding this comment.
Suggested change
| The **number of columns** Output from the Custom Query should be **equal to to number of metrics variables** in the conf.yaml file shown below. | |
| The **number of columns** output from the Custom Query should be equal to to number of metrics variables in the `conf.yaml` file shown below. |
temporal-github-worker-1
bot
added
docs/approved
and removed
docs/review-requested
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Provides additional information about Custom Queries. Adds the key configuration information number of columns from the query should equal the number of custom query metrics in the conf.yaml file
Motivation
This information is not present in the documentation, rather in the example conf.yaml file.
This makes it easy to read from the documentation
Review checklist (to be filled by reviewers)
qa/skip-qalabel if the PR doesn't need to be tested during QA.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged