Skip to content

Bump redis dependency to 6.0.0 #20265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 27, 2025
Merged

Bump redis dependency to 6.0.0 #20265

merged 5 commits into from
May 27, 2025

Conversation

sarah-witt
Copy link
Contributor

@sarah-witt sarah-witt commented May 12, 2025

What does this PR do?

Bumps redis version to 6.0.0: https://github.com/redis/redis-py/releases/tag/v6.0.0
It includes some breaking changes such as removing previously deprecated fields that we supported.

Additionally, removes support for the connection_pool argument as we do not document it and it is has to be a valid ConnectionPool object.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (40e4f36) to head (53b63b1).
Report is 50 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
confluent_platform ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
redisdb 89.72% <100.00%> (+0.98%) ⬆️
solr ?
tomcat ?
weblogic ?

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sarah-witt sarah-witt marked this pull request as ready for review May 12, 2025 21:41
@sarah-witt sarah-witt requested a review from a team as a code owner May 12, 2025 21:41
Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

steveny91
steveny91 previously approved these changes May 12, 2025
@temporal-github-worker-1 temporal-github-worker-1 bot dismissed steveny91’s stale review May 15, 2025 18:53

Review from steveny91 is dismissed. Related teams and files:

  • agent-integrations
    • redisdb/tests/test_unit.py
@datadog-datadog-prod-us1
Copy link

Datadog Summary

❌ Dependencies


Was this helpful? Give us feedback!

Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@sarah-witt sarah-witt added this pull request to the merge queue May 27, 2025
Merged via the queue into master with commit 30709e2 May 27, 2025
31 checks passed
@sarah-witt sarah-witt deleted the sarah/bump-redisdb-version branch May 27, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants