Skip to content

Conversation

r1viollet
Copy link
Collaborator

@r1viollet r1viollet commented Jul 8, 2025

What does this PR do?:

Lower threshold for allocation test

Motivation:

Failure in followinb build:
https://github.com/DataDog/java-profiler/actions/runs/16139567049/job/45543862207?pr=240

Additional Notes:

How to test the change?:

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-XXXX]

Unsure? Have a question? Request a review!

Lower threshold for allocation test
Copy link

github-actions bot commented Jul 8, 2025

🔧 Report generated by pr-comment-cppcheck

CppCheck Report

Errors (2)

Warnings (4)

Style Violations (297)

Copy link

github-actions bot commented Jul 8, 2025

🔧 Report generated by pr-comment-scanbuild

Copy link
Collaborator

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's see if the flakiness will be gone.

@r1viollet r1viollet merged commit c024517 into main Jul 8, 2025
184 of 185 checks passed
@r1viollet r1viollet deleted the r1viollet/fix_flaky_alloc_test branch July 8, 2025 12:21
@github-actions github-actions bot added this to the 1.29.0 milestone Jul 8, 2025
zhengyu123 pushed a commit that referenced this pull request Jul 9, 2025
Lower threshold for allocation test
zhengyu123 added a commit that referenced this pull request Jul 9, 2025
* Potential memory leak with the JVMTI wallclock sampler

* v1

* Don't sample terminated thread

* v2

* v3

* v4

* Safe access

* Fix thread state

* v5

* Cleanup

* Cleanup

* safeFetch impl

* jdk11 support

* v6

* enhance and cleanup

* fix nullptr deference

* More cleanup

* Erwan's finding

* Fixed memory leak found by Erwan

* [Automated] Bump dev version to 1.29.0

* Update the sonatype repos (#235)

* Fix artifact download URL

* Split debug (#233)

* Split debug
Add build steps to store split debug information for release builds

* Add the micro-benchmark for thread filtering (#237)

* Add the micro-benchmark for thread filtering

* Do not test for obviously invalid thread id

* Relax threadfilter mem order

* Flaky test - j9 OSR (#239)

Skip zing and j9 flaky tests

* Fix flaky allocation test (#241)

Lower threshold for allocation test

* jbachorik's comments

* More jbachorik's comments

* Cleanup thread local references

---------

Co-authored-by: zhengyu.gu <[email protected]>
Co-authored-by: Datadog Java Profiler <[email protected]>
Co-authored-by: Jaroslav Bachorik <[email protected]>
Co-authored-by: Jaroslav Bachorik <[email protected]>
Co-authored-by: r1viollet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants