Encapsulate JsonParser error type #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
ygree
force-pushed
the
ygree/jsonparser-error-type
branch
from
7ffa42a to
1716bc3
Compare
Hide the jackson exception inside the wrapper to avoid a dependency on jackson outside of this class to distinguish between IO and JSON errors. It's needed for Java Tracer, which embeds JMXFetch, excluding jackson transitive dependencies that are not needed or exercised for Java Tracer use cases.
ygree
force-pushed
the
ygree/jsonparser-error-type
branch
from
1716bc3 to
290f27d
Compare
carlosroman
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide the jackson exception inside the wrapper to avoid a dependency on jackson outside of this class to distinguish between IO and JSON errors. It's needed for Java Tracer, which embeds JMXFetch, excluding jackson transitive dependencies that are not needed or exercised for Java Tracer use cases.
This is required for Java Tracer, which has JMXFetch embedded in native builds builds DataDog/dd-trace-java#8569.