Skip to content

Conversation

svenfuchs
Copy link
Contributor

This brings back a green build on Travis CI at the expense of skipping cucumber features, and some Mongo truncation tests.

@svenfuchs svenfuchs changed the title Fix travis Fix Travis CI Mar 24, 2018
@svenfuchs
Copy link
Contributor Author

svenfuchs commented Mar 24, 2018

There's an unstable spec in ./spec/database_cleaner/moped/truncation_spec.rb:57 that I've seen fail twice with:

MopedTest::Widget expected to have a count of 0 but was 0

Restarting the job on Travis CI would then fix that.

@svenfuchs
Copy link
Contributor Author

I thought c1251d5 might address that issue, but it's still happening: https://travis-ci.org/DatabaseCleaner/database_cleaner/jobs/357828880.

@etagwerker
Copy link
Member

@svenfuchs Thanks for this!

Months ago I did some research on these failures and it seems to be related to the versions of the mongo adapters that we were using when we had Gemfile.lock in the repo. When I removed it, it started failing.

I think marking the failing specs as pending or commenting them out is okay.

A couple of years ago I started https://github.com/DatabaseCleaner/database_cleaner/tree/2-0 but I had to switch focus and never went back to it. The goal of that branch is to have smaller db cleaner gems (one per ORM). Another goal was to resolve the development dependency hell associated with this gem, which in turn would help with maintainability.

@etagwerker etagwerker merged commit bdd3537 into DatabaseCleaner:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants