Sp/selects #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

shalane-proctor wants to merge 10 commits into main from sp/selects

Contributor

shalane-proctor commented Dec 10, 2024

No description provided.

decisiveJoe and others added 5 commits

December 9, 2024 10:29


          chore: Checkbox WIP

353639c


          Feat: Added select and multiselect, merged checkbox.

37545a7


          Feat/Fix: Updated onClicks to onclick on button. Fix all issues with …

3fc5a17

…button throughout. Added CheckboxGroup, updated checkbox. Unable to get errored checkbox to work.


          style: Refine styles for checkbox error, interaction states

36d18c0


          Merge pull request #17 from DecisiveAI/checkbox-error-styles

5f98725

style: Refine styles for checkbox error, interaction states

shalane-proctor marked this pull request as ready for review

December 12, 2024 22:57


          Merge branch 'main' into sp/selects

d289d2a

shalane-proctor commented

View reviewed changes

package.json Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/button/Button.stories.ts Outdated Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/button/Button.svelte Outdated Show resolved Hide resolved


          Chore removed unused testing from button

fbd7005

decisiveJoe reviewed

View reviewed changes

src/checkbox/Checkbox.svelte Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/checkbox/Checkbox.svelte Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/checkbox/CheckboxGroup.svelte Outdated Show resolved Hide resolved


          Chore: Updated handleChange to handleClick

15ff0e9

decisiveJoe reviewed

View reviewed changes

src/checkbox/CheckboxGroup.svelte Outdated Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/checkbox/CheckboxGroup.svelte Outdated Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/select/Select.svelte Outdated Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/multiselect/MultiSelect.svelte Outdated Show resolved Hide resolved


          Chore: added value to cb w/o label. Added decorator for selects. Remo…

ed30e8a

…ved unneeded parent divs. Updated select variant and style.

decisiveJoe reviewed

View reviewed changes

src/select/Select.svelte Outdated Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/select/Select.svelte Outdated Show resolved Hide resolved

decisiveJoe reviewed

View reviewed changes

src/multiselect/MultiSelect.svelte Outdated Show resolved Hide resolved

decisiveJoe previously approved these changes

View reviewed changes

Contributor

decisiveJoe left a comment

Minor questions/nits. Nothing blocking


          Chore: Added selections to Multiselect props, removed form SB options…

7ab4f4f

…. Removed height and selected on select

shalane-proctor dismissed decisiveJoe’s stale review via

7ab4f4f

December 13, 2024 19:14

decisiveJoe approved these changes

View reviewed changes

Contributor

decisiveJoe left a comment

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet