[FIX] Add dtype property to SymbolicExprDataWrapper #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SymbolicExprDataWrapper was missing a dtype property, causing AttributeError when triton's create_ashr tried to access lhs.data.dtype. This fix adds a dtype property that returns the dtype from the underlying symbolic expression, with a fallback to np.int64 for integer operations. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Jokeren
reviewed
Aug 18, 2025
| ): | ||
| return self.symbolic_expr.dtype_tt | ||
| # Default to int64 if no dtype is available (common for integer operations) | ||
| return np.int64 |
There was a problem hiding this comment.
Please attach the test case, it doesn't seem correct to always fallback to np.int64.
Triton's logic is to assign scalars as int32 or int64 based on their values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SymbolicExprDataWrapper was missing a dtype property, causing AttributeError when triton's create_ashr tried to access lhs.data.dtype. This fix adds a dtype property that returns the dtype from the underlying symbolic expression, with a fallback to np.int64 for integer operations.
🤖 Generated with Claude Code