Skip to content

Feat/mention trigger #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

moeyue23
Copy link

@moeyue23 moeyue23 commented Aug 7, 2025

No description provided.

@fu050409
Copy link
Member

fu050409 commented Aug 7, 2025

@moeyue23 Could you please help with merging main branch and solve the conflicts? A large number of loose file changes since your branch has not been updated with main branch.

@fu050409 fu050409 requested a review from Raven-Book August 7, 2025 11:58
@moeyue23
Copy link
Author

moeyue23 commented Aug 8, 2025

@fu050409 Sure! I’ll merge the latest main into my branch and resolve the conflicts as soon as possible.

@@ -0,0 +1,12 @@
// slash command
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? It seems that these should be passed from the user.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not be necessary, but idk how to do it properly, so I just followed the example from https://matechat.gitcode.com/components/mention/demo.html

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not be necessary, but idk how to do it properly, so I just followed the example from https://matechat.gitcode.com/components/mention/demo.html

All contributors to MateChat React were interfered with by Vue's documentation in their judgment. We don't need to refer to the implementation and solutions of Vue. We just need to ensure that what Vue has, we also have. I think most of the time, the content of Vue documentation only tells us which components need to be implemented, and in fact, it has no other reference value.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, idk how to implement it so that it’s passed from the user😂😂

It might not be necessary, but idk how to do it properly, so I just followed the example from https://matechat.gitcode.com/components/mention/demo.html这可能不是必要的,但我不知道如何正确地做,所以我就参考了 https://matechat.gitcode.com/components/mention/demo.html 的示例。

All contributors to MateChat React were interfered with by Vue's documentation in their judgment. We don't need to refer to the implementation and solutions of Vue. We just need to ensure that what Vue has, we also have. I think most of the time, the content of Vue documentation only tells us which components need to be implemented, and in fact, it has no other reference value.MateChat React 的所有贡献者在判断时都被 Vue 的文档干扰了。我们不需要参考 Vue 的实现和解决方案。我们只需要确保 Vue 有的东西,我们也有。我认为大多数情况下,Vue 文档的内容只是告诉我们需要实现哪些组件,实际上它并没有其他参考价值。

@@ -120,7 +123,49 @@ export function Sender({
const textareaRef = useRef<HTMLTextAreaElement>(null);
const [message, setMessage] = useState(initialMessage);
const [isSending, setIsSending] = useState(false);
const [showCommandList, setShowCommandList] = useState(false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be wrapped into a separate component? Also, could you please provide an image or video to show the effect?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I’ll give it a try. Here’s the current image showing the effect:
屏幕截图_8-8-2025_224122_127 0 0 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moeyue23 I prefer the effects like GitHub comments:

image

Of course, if this difficult to achieve, you can also refer to https://x.ant.design/components/suggestion-cn. Although Ant Design is completely a opportunistic solution.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, I think it might be better to use a lighter text color. :D

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I’ll try changing it! 🫠

@fu050409
Copy link
Member

fu050409 commented Aug 8, 2025

@moeyue23 Some checks failed, please run pnpm lint:fix before every commits. I think we should setup husky in our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants