[pull] master from CompuIves:master #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* additional parameters to zeit deployment Right now it's impossible to add additional parameters to zeit deployment like `env` or `region` even though I'd add to the `now.json`. With this change all the supported parameters which are listed on the [zeit documentation](https://zeit.co/docs/api#endpoints/deployments) are supported. * added oroce to the contributors Also I fixed the table because the previous contributor `Abdullah` wasn't visible.
If you omit the `files` entry in your `now.json` then the deployment works without any issues but if you customize the `now.files` and you happen to have `package.json` in that list, it will be ignored from the deployment. If the package.json is omitted then zeit won't install the required dependencies.
Example configuration:
now.json
```
{
"version": 2,
"files": [
"index.js",
"package.json"
],
"builds": [{
"src": "index.js",
"use": "@now/node"
}]
}
```
package.json
```
{
"dependencies": {
"express": "4.16.4"
}
}
```
index.js
```
require('express');
```
The deployment of a sandbox with the configuration above will be successful but when you are trying to open your deployment it'll crash with an error of 500. (`MODULE_NOT_FOUND`)
I found this issue while I was building a Pusher authentication server using zeit for a [sample vue chat app](https://codesandbox.io/s/9z1prn05pr). I had to define the `now.files` since the sandbox has lots of files (config, static, build, etc) which should be deployed to zeit (and cannot be due to some zeit errors). For now, I moved the server to a different sandbox and deployed from [there](https://codesandbox.io/s/j4v80y7wzw).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]