bxdf fixes: non cook-torrance stuff #919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+929
to
945
| #define NBL_CONCEPT_TPLT_PRM_NAMES (T) | ||
| #define NBL_CONCEPT_PARAM_0 (bxdf, T) | ||
| #define NBL_CONCEPT_PARAM_1 (_sample, typename T::sample_type) | ||
| #define NBL_CONCEPT_PARAM_2 (aniso, typename T::anisotropic_interaction_type) | ||
| #define NBL_CONCEPT_PARAM_3 (anisocache, typename T::anisocache_type) | ||
| NBL_CONCEPT_BEGIN(4) | ||
| #define bxdf NBL_CONCEPT_PARAM_T NBL_CONCEPT_PARAM_0 | ||
| #define _sample NBL_CONCEPT_PARAM_T NBL_CONCEPT_PARAM_1 | ||
| #define aniso NBL_CONCEPT_PARAM_T NBL_CONCEPT_PARAM_2 | ||
| #define anisocache NBL_CONCEPT_PARAM_T NBL_CONCEPT_PARAM_3 | ||
| NBL_CONCEPT_END( | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::scalar_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::isotropic_interaction_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::anisotropic_interaction_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::sample_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::spectral_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::quotient_pdf_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::isocache_type)) | ||
| ((NBL_CONCEPT_REQ_TYPE)(T::anisocache_type)) |
There was a problem hiding this comment.
why not check bxdf_common instead of all the typedefs for scalar, specral, etc. ?
There was a problem hiding this comment.
Functions in microfacet bxdfs also take cache. Checking bxdf_common would fail because those don't take cache (it's for the non cook torrance bxdfs). Probably a naming problem.
There was a problem hiding this comment.
yeah you'd have to split bxdf_common into typedef checking and then function checking on top
include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/bxdf/transmission/delta_distribution.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/bxdf/transmission/delta_distribution.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/bxdf/reflection/delta_distribution.hlsl
Outdated
Show resolved
Hide resolved
include/nbl/builtin/hlsl/bxdf/transmission/delta_distribution.hlsl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.