Skip to content

Instrument Server Fixes #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 8, 2025
Merged

Instrument Server Fixes #560

merged 7 commits into from
Apr 8, 2025

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Apr 4, 2025

  • Added logic to instrument server's 'upload_gain_reference()' function to look for 'rsync_path' key from MachineConfig before settling on using Murfey's URL.
  • Added logs to describe parameters passed to functions for more effective debuging.

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 28.78%. Comparing base (9ea4921) to head (123840f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #560      +/-   ##
==========================================
- Coverage   28.80%   28.78%   -0.02%     
==========================================
  Files          80       80              
  Lines       10596    10605       +9     
  Branches     1413     1414       +1     
==========================================
+ Hits         3052     3053       +1     
- Misses       7442     7450       +8     
  Partials      102      102              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin requested a review from d-j-hatton April 7, 2025 12:15
@tieneupin tieneupin self-assigned this Apr 7, 2025
@tieneupin tieneupin added the client Relates to the client component label Apr 7, 2025
@tieneupin tieneupin marked this pull request as ready for review April 7, 2025 12:16
@d-j-hatton d-j-hatton merged commit 8567d8d into main Apr 8, 2025
17 checks passed
@d-j-hatton d-j-hatton deleted the feedback-callback-fix branch April 8, 2025 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Relates to the client component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants