Skip to content

CLEM workflow fix #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

CLEM workflow fix #594

wants to merge 10 commits into from

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented May 20, 2025

  • Tidied up MachineConfig and Security model and added settings to control parsing and JSON serialising behaviour
  • Get the 'MachineConfig' directly from the backend server instead of passing around a new, half-populated instance of the config
  • Fixed logic used to create destination file paths for CLEM context
  • Added logs to keep track of key CLEM workflow stages

Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.23%. Comparing base (f0ff051) to head (004e6f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   30.18%   30.23%   +0.05%     
==========================================
  Files          80       80              
  Lines       10576    10590      +14     
  Branches     1409     1410       +1     
==========================================
+ Hits         3192     3202      +10     
- Misses       7278     7282       +4     
  Partials      106      106              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tieneupin added a commit that referenced this pull request May 28, 2025
* Refactored 'murfey.server' API endpoints so that they can be covered by different authentication methods
* Replaced hard-coded URLs with function that constructs URL based on a provided router and function name
* Added CLI 'murfey.generate_route_manifest' to generate up-to-date route manifests
* Migrated server startup and feedback functions to separate modules
* Fixed CLEM workflow to run on instrument server (see PR #594)

---------

Co-authored-by: Eu Pin Tien <[email protected]>
@tieneupin
Copy link
Contributor Author

Incorporated into PR #595

@tieneupin tieneupin closed this May 28, 2025
@tieneupin tieneupin deleted the clem-workflow-fix branch May 28, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant