Improve default user creation logic at startup #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the default user creation logic in
server/main.goto improve clarity and robustness.Previously, the default user was only added if a password was provided in the configuration. This change ensures the default user (specified by
config.Config.Username) is always added to theauth.UserStoreat startup. The user's password is now set conditionally .This addresses the TODO comment about handling user addition better, and I attempted to decouple the user's existence from its password configuration.
Testing:
The relevant tests for the underlying authentication functions (
TestUsersAddAndGet,TestUserSetPassword,TestNewSession) ininternal/auth/session_test.gowere run and passed successfully.Important Note: The test file
internal/auth/session_test.gohad pre-existing compile errors unrelated to this change. Parts of the file had to be temporarily commented out to execute the relevant tests. Please do correct me if I am wrong.