feat(wal): wal support for ironhawk server #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshwinKul28
force-pushed
the
master
branch
2 times, most recently
from
ea7cd33 to
a668de5
Compare
internal/wal/gen_wal_proto.sh
Outdated
Comment on lines
6
to
15
| # Define the directory where the proto file will be downloaded | ||
| PROTO_DIR=$(dirname "$0") | ||
| OUTPUT_DIR="$PROTO_DIR" | ||
|
|
||
| # Define the proto file and the output file | ||
| # Define the GitHub repository and file path | ||
| GITHUB_REPO="AshwinKul28/dicedb-protos" | ||
| GITHUB_BRANCH="patch-1" | ||
| PROTO_FILE_PATH="wal/wal.proto" | ||
| PROTO_FILE="$PROTO_DIR/wal.proto" | ||
| OUTPUT_DIR="." | ||
|
|
There was a problem hiding this comment.
OUr protos dependency is taken through dicedb-go package which takes it from dicedb-protos. We need not be doing this here. The generates WAL protos can be part of dicedb-go.
arpitbbhayani
requested changes
May 15, 2025
| return fmt.Errorf("failed to marshal command payload: %w", err) | ||
| } | ||
|
|
||
| return wal.writeEntry(payloadBytes) | ||
| } |
There was a problem hiding this comment.
What happens if lsn is incremented and assigned but the writeEntry returns an error. Won't WAL have entries with skipped LSN in this case. Is this fine as long as LSN is incrementing or should we check for error here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following:
Few Pointers to consider while adding WAL into ironhawk
Have added WAL into the ironhawk server rather than ShardManager because of the following reasons:
The ShardManager is responsible for managing data shards and their operations
The Ironhawk server is responsible for handling network connections and command processing
WAL is more closely related to command processing and persistence at the server level
The ShardManager is a lower-level component that shouldn't need to know about persistence mechanisms
The Ironhawk server is the higher-level component that coordinates between different parts of the system
WAL is a server-level feature that should be managed by the server component
Summary: