Renderers are now packages, not features. #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkelleyrtp
force-pushed
the
jk/sync-router
branch
from
3963146 to
b28a3f1
Compare
jkelleyrtp
changed the title
This was referenced Jul 7, 2022
jkelleyrtp
force-pushed
the
jk/sync-router
branch
from
08aa20c to
4c84e37
Compare
jkelleyrtp
added
breaking
jkelleyrtp
force-pushed
the
jk/sync-router
branch
from
2c8a683 to
4136790
Compare
rMazeiks
reviewed
Jul 7, 2022
| @@ -0,0 +1,185 @@ | |||
| //! Example: Antipatterns | |||
There was a problem hiding this comment.
i deleted some of these examples when i re-wrote the guide
the guide now contains the parts of this info i found important, in a more concise form
any reason for adding them back or just git merge madness?
There was a problem hiding this comment.
merge madness :) I need to figure out which ones slipped through
| } | ||
| }); | ||
|
|
||
| cx.provide_context(svc) |
There was a problem hiding this comment.
deleting this seems sus and unrelated, is it intentional?
ealmloff
requested changes
Jul 7, 2022
There was a problem hiding this comment.
This seems much more organized. 🙂
A few things I noticed that don't fit specific lines:
- There are some dioxus::{plaform} imports left in the docs/guide/examples
- The tui_benchmark should probably be moved from the dioxus to the tui crate
- I think we can remove rsx-prelude now
Closed
jkelleyrtp
force-pushed
the
jk/sync-router
branch
from
e90fb20 to
bacda49
Compare
jkelleyrtp
force-pushed
the
jk/sync-router
branch
from
bacda49 to
edd148d
Compare
amindWalker
pushed a commit
to amindWalker/dioxus
that referenced
this pull request
Jul 10, 2022
* feat: use synchronous router design * feat: function to get router out of dom * chore: restructure workspace to use renderers as packages, not features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we do packages since things have started to become unwieldy when adding functionality to crates like the router, fermi, and 3rd party renderers.
Now, all renderers are their own package and need to be added to Cargo.toml as such:
Instead of
dioxus::web::launchyou'll dodioxus_web::launch.For releases, we'll using the minor version to keep things in lock step, but freely bump minor versions as new updates are pushed. It should've been this way since the beginning but I was experimenting. This also gets rid of the rsx-prelude which was a patch until we had a better solution.
The benefits:
The stuff that remains under "dioxus" includes: