Detector #10
Merged
Detector #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
6
to
13
| import torchvision # type: ignore | ||
| import numpy as np | ||
| from transformers import Owlv2Processor, Owlv2ForObjectDetection, Owlv2VisionModel # type: ignore | ||
| from transformers.models.owlv2.modeling_owlv2 import Owlv2Attention # type: ignore | ||
| import time | ||
| from typing import Union | ||
| from torch_scatter import scatter_max # type: ignore | ||
| from flash_attn import flash_attn_func # type: ignore |
There was a problem hiding this comment.
why are we ignoring typing on these?
There was a problem hiding this comment.
none of them come with typing annotations, so mypy is complaining and that can't be resolved .. is there something better I can do?
There was a problem hiding this comment.
don't think it demands a change. in the spirit of a well-typed repo we should probably provide justification for ignoring typing in any given change (e.g. linking something like this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the object detector, complete with batched runs. Took out flash attention from the text encoder because it is not obvious that the behavior is the same