Support Django 4.x

[tulgaab]

Traceback (most recent call last): File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/threading.py", line 932, in _bootstrap_inner self.run() File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/threading.py", line 870, in run self._target(*self._args, **self._kwargs) File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django/utils/autoreload.py", line 64, in wrapper fn(*args, **kwargs) File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django/core/management/commands/runserver.py", line 125, in inner_run autoreload.raise_last_exception() File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django/utils/autoreload.py", line 87, in raise_last_exception raise _exception[1] File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django/core/management/__init__.py", line 398, in execute autoreload.check_errors(django.setup)() File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django/utils/autoreload.py", line 64, in wrapper fn(*args, **kwargs) File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django/__init__.py", line 24, in setup apps.populate(settings.INSTALLED_APPS) File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django/apps/registry.py", line 91, in populate app_config = AppConfig.create(entry) File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django/apps/config.py", line 228, in create import_module(entry) File "/Library/Frameworks/Python.framework/Versions/3.8/lib/python3.8/importlib/__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "<frozen importlib._bootstrap>", line 1014, in _gcd_import File "<frozen importlib._bootstrap>", line 991, in _find_and_load File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked File "<frozen importlib._bootstrap>", line 671, in _load_unlocked File "<frozen importlib._bootstrap_external>", line 783, in exec_module File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django_admin_row_actions/__init__.py", line 1, in <module> from .admin import AdminRowActionsMixin File "/Users/khureltulga/Documents/GitHub/redrockweb/.env/lib/python3.8/site-packages/django_admin_row_actions/admin.py", line 3, in <module> from django.conf.urls import url ImportError: cannot import name 'url' from 'django.conf.urls'

[amaddio]

Related to this issue. I am updating from Django 3.2 to 4.2 (through 4.1). The error above is raised. Is there a newer version of django-admin-row-actions that fixes the problem?

If not, would you mind pulling my changes if I create a fork?

[jamesrampton]

Hi @amaddio you can find Django 4 compatibility in the feature/django4 branch here: https://github.com/DjangoAdminHackers/django-admin-row-actions/tree/feature/django4

Thanks for submitting your PR; those changes are already in that branch though.

[amaddio]

Ah, thanks @jamesrampton. Great that there has been progress on this. Unfortunately, there is no release of this branch on PyPI. How can one install that package from a package manager (e.g. Poetry)?

[amaddio]

Never mind. I figured it out. In Poetry one could use: poetry add "git+https://github.com/DjangoAdminHackers/django-admin-row-actions.git@feature/django4" -vvv.

Are you planning on releasing, tagging or merging the other branch so that one would be able to retrieve future changes?

[blag]

@amaddio Working on that in PR #28. Do you mind giving that a quick review?

Looking forward to having this available on PyPI. 😄

[amaddio]

@blag sure. Feel free to add me as a reviewer. I am not a repo contributor yet but I don't mind to be ;-)

[blag]

I cannot add you as a reviewer, I think it's because you aren't a collaborator on this repository and you are not involved with that PR yet.

So if those changes look good to you, please drop a 👍 in the comments or something.

[amaddio]

@blag here is my review: #28 (review)

[blag]

Version 0.1.0 is now available on PyPI and GitHub and contains support for Django 4.