Skip to content

matklad.rust-analyzer is out of date #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimonSapin opened this issue May 11, 2021 · 4 comments
Closed

matklad.rust-analyzer is out of date #342

SimonSapin opened this issue May 11, 2021 · 4 comments

Comments

@SimonSapin
Copy link

https://open-vsx.org/extension/matklad/rust-analyzer currently lists version 0.2.563 as "latest", whereas https://marketplace.visualstudio.com/items?itemName=matklad.rust-analyzer has version 0.2.591.

It looks like the last update was made by @jankeromnes in #333. Are such updates automated? Is making a new one blocked on something?


For context, I reported a bug rust-lang/rust-analyzer#8792 upstream and only when investigating that did I realize that the Archlinux build of Code OSS uses open-vsx.org instead of Microsoft’s Marketplace.

rust-analyzer’s development is rather active these days, so it can be misleading to have Code OSS say "All extensions are up to date" when in fact an old, buggy version is being used. If automating updates turns out difficult it might be better to not have this extension on open-vsx at all rather than have an old version that claims to be the latest.

@jankeromnes
Copy link
Collaborator

Salut Simon ! 👋 😁

It looks like the last update was made by @jankeromnes in #333. Are such updates automated? Is making a new one blocked on something?

Whoops, good catch. These updates are indeed automated, but it looks like the automation started failing 2-3 weeks ago:

https://github.com/open-vsx/publish-extensions/actions/workflows/upgrade-extensions.yml

Will investigate & fix.


On a side note, this may be a good time to re-consider publishing to OpenVSX from the rust-analyzer repository itself (see also rust-lang/rust-analyzer#4936, rust-lang/rust-analyzer#5509 and rust-lang/rust-analyzer#5688).

The fix is actually as easy as adding a single at the bottom of .github/workflows/release.yaml. The line is:

&& npx ovsx publish --pat ${{ secrets.OVSX_TOKEN }} --packagePath ../../dist/rust-analyzer.vsix

jankeromnes added a commit that referenced this issue May 11, 2021
jankeromnes added a commit that referenced this issue May 11, 2021
@jankeromnes
Copy link
Collaborator

Update: Fixed in https://github.com/open-vsx/publish-extensions/pull/343/files

Latest matklad.rust-analyzer should get auto-published tonight (along with a bunch of other upgrades).

Thanks for reporting the broken auto-upgrades!

@SimonSapin
Copy link
Author

Thanks for the quick fix!

I see that #342 is submitted from your personal account (rather than some bot account). Does it mean you make PRs like this manually?

@jankeromnes
Copy link
Collaborator

Thanks for the quick fix!

You're very welcome! 🙌

I see that #342 is submitted from your personal account (rather than some bot account). Does it mean you make PRs like this manually?

So,

tennox pushed a commit to tennox/publish-extensions that referenced this issue Jan 21, 2022
tennox pushed a commit to tennox/publish-extensions that referenced this issue Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants