Added location to all events (In-person && Remote) #4438
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
github-actions
bot
added
the
medium
|
Hi @Pradumnasaraf, can you please review this PR? |
|
Hey @ManishBisht777 and @Pradumnasaraf, updated the code, so that even if we do not give any Also in the docs, it is NOT mandatory. |
|
Hey @Pradumnasaraf, requesting you to review this PR. |
Hey, thanks for the PR. I don't look at frontend. Some will soon review it. Also, you don't need to tag any maintainers, it creates an extra notification. Thank you for your patience. |
|
Hey @eddiejaoude , this Pr is ready for review. Merging this would unblock the other map related issues. |
|
Thank you! Sorry for my slow review, we have a lot of PRs coming in. This is on my list of things to do |
* feat: location to events (#4438) * Added the Location parameters * Updated docs with Location parameters * Updated the Location parameter * Updated location docs * Updated the location parameters --------- Co-authored-by: Eddie Jaoude <[email protected]> * feat: event location --------- Co-authored-by: Deb Chatterjee <[email protected]>
closes #4132
I have made a working prototype of the location parameter in events. Also I have updated the docs too. Please have a look at the screenshot and let me know if you like it or not -->
(The Docs containing the location parameter. Now all the required flags are true, because if the InPerson flag is set as true, then you need to set the location parameters. Otherwise, means if isVirtual is set as true && isInPerson is false, then by fault the location will be remote)
(It is the layout of the events page containing the location)
Please suggest, if I should make any changes in the layout or not!
Fixes Issue #4132
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers