Skip to content

Fix regression in hsmd for elements-based chains #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2020
Merged

Fix regression in hsmd for elements-based chains #3491

merged 1 commit into from
Feb 8, 2020

Conversation

cdecker
Copy link
Member

@cdecker cdecker commented Feb 7, 2020 •
edited
Loading

Consider this a minimal fix of #3487, there are a couple of other places in which we don't tal_resize the output_witscript array to the correct length, but I'll fix those up in a cleanup PR.

Closes #3487

Changelog-None

@cdecker cdecker added this to the 0.8.1 milestone Feb 7, 2020
@cdecker cdecker requested a review from rustyrussell February 7, 2020 20:20
@cdecker cdecker self-assigned this Feb 7, 2020
rustyrussell
rustyrussell approved these changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack 4bccdb5

@cdecker cdecker merged commit 9521549 into ElementsProject:master Feb 8, 2020
cdecker added a commit to cdecker/lightning that referenced this pull request Feb 8, 2020
@cdecker
tx: Strengthen transaction construction checks
fa69ea4 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Feb 19, 2020
@cdecker
tx: Strengthen transaction construction checks
3507d0e 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Feb 26, 2020
@cdecker
tx: Strengthen transaction construction checks
4dbd450 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Mar 4, 2020
@cdecker
tx: Strengthen transaction construction checks
c96435e 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Mar 4, 2020
@cdecker
tx: Strengthen transaction construction checks
46d2a0d 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Mar 6, 2020
@cdecker
tx: Strengthen transaction construction checks
1cb6468 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Mar 9, 2020
@cdecker
tx: Strengthen transaction construction checks
0bc57e0 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Mar 16, 2020
@cdecker
tx: Strengthen transaction construction checks
9077463 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Mar 17, 2020
@cdecker
tx: Strengthen transaction construction checks
46e9b4c 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
rustyrussell pushed a commit to cdecker/lightning that referenced this pull request Mar 22, 2020
@cdecker @rustyrussell
tx: Strengthen transaction construction checks
1b38852 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
cdecker added a commit to cdecker/lightning that referenced this pull request Mar 23, 2020
@cdecker
tx: Strengthen transaction construction checks
3eaa7a5 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in ElementsProject#3491
rustyrussell pushed a commit that referenced this pull request Mar 23, 2020
@cdecker @rustyrussell
tx: Strengthen transaction construction checks
42a63e4 
We roll the `elements_add_fee_output` function and the cropping of
overallocated arrays into the `bitcoin_tx_finalize` function. This is supposed
to be the final cleanup and compaction step before a tx can be sent to bitcoin
or passed off to other daemons.

This is the cleanup promised in #3491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustyrussell rustyrussell rustyrussell approved these changes

Assignees

@cdecker cdecker

Labels
None yet
Projects
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.

Regression for sign_tx_request in hsmd when running in liquid-regtest configuration
2 participants
@cdecker @rustyrussell