fix(channeld): handle NULL short_channel_id in AWAITING_LOCKIN state #8435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7222 crash when reconnecting channels in
CHANNELD_AWAITING_LOCKIN
state withoutshort_channel_id
.The issue occurred when channels stuck in
AWAITING_LOCKIN
state (with missing funding tx) attempted to reconnect. The code passed a zero-initialized scid struct totowire_channeld_init
, causing a crash when accessingshort_channel_id.u64
.Changes:
peer_start_channeld
to use pointer for scid instead of structchanneld
wire protocol to handle optionalshort_channel_id
connect_activate_subd
for NULL scidchanneld
now falls back to local_alias whenhas_funding_short_id
is false