Skip to content

Conversation

nepet
Copy link
Collaborator

@nepet nepet commented Oct 9, 2025

Using tal_dup_or_null does not set the tal context to the included bytes array. Luckily we already have a function that deeply duplicates a feature_set: feature_set_dup

Setting Changelog-None as the feature has been introduced and fixed on the same version.

Changelog-None

Using `tal_dup_or_null` does not set the tal context to the included
bytes array. Luckily we already have a function tha deeply duplicates
a `feature_set`: `feature_set_dup`

Signed-off-by: Peter Neuroth <[email protected]>
@nepet nepet changed the title Fix feature_set allocation on getmanifest callback DRAFT: Fix feature_set allocation on getmanifest callback Oct 9, 2025
a plugin is disabled during init.

Signed-off-by: Peter Neuroth <[email protected]>
@nepet nepet changed the title DRAFT: Fix feature_set allocation on getmanifest callback Fix feature_set allocation on getmanifest callback Oct 9, 2025
Copy link
Contributor

@rustyrussell rustyrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 32ab8fc


@plugin.init()
def init(configuration, options, plugin):
disable = os.getenv("PLUGIN_DISABLE")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but a normal parameter would be more usual?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants