Skip to content

Remove old search handler before adding the new one. #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove old search handler before adding the new one. #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b0af69
Remove old search handler before adding the new one.
peterjaric Oct 20, 2014
dc83836
getSelectedValues() now handles multiple select values (arrays).
peterjaric Oct 27, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,12 @@
var vals = [];

criteria.$ele.filter(criteria.selector).each(function() {
vals.push($(this).val());
var value = $(this).val();
if (value instanceof Array) {
vals = vals.concat(value);
} else {
vals.push(value);
}
});

if(criteria.type == 'range'){
Expand Down Expand Up @@ -325,15 +330,23 @@

//Search
var bindSearchEvent = function(searchBox, timeout, context){
$('body').on('keyup', searchBox, function(e){
var handler = function(e){
if (context.searchTimeoutId) {
clearTimeout(context.searchTimeoutId);
}
context.searchTimeoutId = setTimeout(function() {
context.filter();
}, timeout);
//context.searchFilter(true);
});
};
$('body').on('keyup', searchBox, handler);
return handler;
};

var unbindSearchEvent = function(searchBox, handler){
if (handler) {
$('body').off('keyup', searchBox, handler);
}
};

F.initSearch = function(opts){
Expand All @@ -350,7 +363,8 @@
if(this.$search_ele.length){
this.has_search = true;
this.searchFn = this.buildSearchFn(opts.fields);
bindSearchEvent(opts.ele, opts.timeout || 0, this);
unbindSearchEvent(opts.ele, this.searchHandler);
this.searchHandler = bindSearchEvent(opts.ele, opts.timeout || 0, this);
}
};

Expand Down