Skip to content

Conversation

pmcgee69
Copy link
Contributor

@pmcgee69 pmcgee69 commented Dec 16, 2020

Targeting #90 - Incorrect editor tabs being closed.
Targeting #32, #76 - Runtime error 216 related to Windows Classic style.

Also micro-typo.

pmcgee69 and others added 2 commits December 16, 2020 10:10
The tab being closed may not be the current tab with cursor / focus.
Closing a tab mutates the PageControl array, so we count down through it.

I'm dubious about the use of TTask in PageControlCloseButtonMouseUp.
@pmcgee69 pmcgee69 changed the title typo / spelling Always close correct editor tab + micro typo. Dec 16, 2020
Moved Style change out of Environment Form Try/Finally.
OnExit hide form and change style to non-Windows Classic.

* Probably needs hard-coded style changed to an auto choice *
@pmcgee69 pmcgee69 changed the title Always close correct editor tab + micro typo. Always close correct editor tab. Runtime error 216 issue. Dec 16, 2020
@pmcgee69
Copy link
Contributor Author

pmcgee69 commented Dec 17, 2020

Welcome screen labels & buttons looked ok in 1366x768 (100% scaling), but bad in 4K (350% scaling).

4K 350%
1366x768 100%

Adjusted result:

4K 350% fixed
1366x768 100% fixed

@FMXExpress FMXExpress merged commit acf2bbf into Embarcadero:master Dec 27, 2020
@pmcgee69
Copy link
Contributor Author

The 216 error only occurs using FASTMM5. Using FASTMM4 or with no MM in uses, there is no error reported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants