-
Notifications
You must be signed in to change notification settings - Fork 249
Investigate clippy failure on example-shader with glam #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
* [spirv-std] Remove math types * Temp implementation of copysign #148 * Convert shader to use glam * Rustfmt * Fix wgpu-example-shader to use glam * [spirv-std] Disable clippy::use_self * Upgrade to latest glam branch * Use latest glam fork * Remove incorrect assert_uninit After discussions with @khyperia * Update lockfile * Update to latest glam fork with fixes * Use real copysign intrinsic * Disable clippy on example-shader for now Tracked in #186
The actual failure is due to panicking with a string, and strings are not supported yet. I added a quick ignored test as a reminder to implement it eventually. rust-gpu/crates/spirv-builder/src/test/basic.rs Lines 37 to 48 in 0b5ddb6
But for why clippy generates code that panics with a string, but normal builds don't, that I have no idea on. I tried investigating for a few hours, and came up with nothing. |
I think I managed to get this problem also when building the shader in debug (so not using |
I think this is probably fixed with eddyb's work |
Running clippy on
example-shader
after the glam conversion in #149 results in:https://github.com/EmbarkStudios/rust-gpu/pull/149/checks?check_run_id=1326417262
it is from our codegen but not sure how we are getting it and needs further investigation
The text was updated successfully, but these errors were encountered: