Use new toolchain file #281
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realistically, blocked on rust-lang/rustup#2579. |
|
I don't see how that blocks this? I think removing the setup scripts and automatically installing components is still valuable even if it installs an extra component on CI, rustup is not where we're spending most of our time in CI anyway. |
|
Yeah, it also seems like the GitHub actions rustup was not up to date, and I don't have time to work out how to work around that at the moment Also I did find a workaround in that thread, so we should use that I might reopen this in the next few days, but it might be worth whoever does the next rust update just doing it anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure where is best to document that we require nightly rust, but in that list of instructions is definitely not it.