Use the same official SPIRV-Tools builds for macOS CI too. #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repi
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #909 (comment) for some context -
brew installis picking up2022.3while we're still only supporting2022.2currently (we should upgrade but it shouldn't block landing other PRs).I've tried to organize and add more documentation (props to @oisyn for showing me Google Cloud Storage XML API docs, it was really hard to get access to historical build versions without that) - so that next time it should be much easier to update all 3 OSes.
However, I didn't touch the Lint builder (should it share an env var? how?) and also there's some Linux/macOS unification that can be done since they're both doing the same thing (assuming that even works).