Support BEGIN as standalon clause #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vedin
force-pushed
the
add-begin-standalone
branch
from
344ebb9 to
4f56f81
Compare
osipovartem
reviewed
Sep 24, 2025
src/parser/mod.rs
Outdated
| pub fn parse_begin_exception_end(&mut self) -> Result<Statement, ParserError> { | ||
| // Snowflake allows BEGIN as a standalone transaction statement (no END). | ||
| // If the next token is a semicolon or EOF, treat it as a standalone BEGIN. | ||
| if dialect_of!(self is SnowflakeDialect) { |
There was a problem hiding this comment.
maybe better to add this directly to snowflake parser
https://github.com/Embucket/datafusion-sqlparser-rs/blob/embucket-sync-df50.0.0-parser0.58.0/src/dialect/snowflake.rs#L134-L136
since this logic will be called before default parser
Vedin
force-pushed
the
add-begin-standalone
branch
from
2e15b90 to
30dacd3
Compare
Vedin
force-pushed
the
add-begin-standalone
branch
from
30dacd3 to
bc002e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.