UNPIVOT command #24
Merged
UNPIVOT command #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note for the reviewers: test doc fails is currently expected. The clippy error is very weird. I figure it out later. If you want it to be clean I can just exclude this part from clippy for now. |
rampage644
reviewed
May 21, 2025
datafusion/sql/src/relation/mod.rs
Outdated
| let mut builder = LogicalPlanBuilder::from(base_plan.clone()) | ||
| .project(projection_exprs)?; | ||
|
|
||
| if null_inclusion |
There was a problem hiding this comment.
nitpick: if let Some(NullInclusion::ExcludeNulls) | None = null_inclusion {
rampage644
reviewed
May 21, 2025
datafusion/sql/src/relation/mod.rs
Outdated
| for column_ident in &columns { | ||
| let column_name = column_ident.value.clone(); | ||
|
|
||
| if let Some(idx) = |
There was a problem hiding this comment.
nitpick: I personally find it easier to read when with an "exit early" approach, subjectively this can be rewritten as
let idx = if let Some(i) = base_schema.index_of_column_by_name(None, &column_name) {
i
} else {
return plan_err!("Column '{}' not found in input", column_name);
};
let field = base_schema.field(idx);
let field_type = field.data_type();
rampage644
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?