Skip to content

Expand CI workflow #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 22, 2023
Merged

Expand CI workflow #119

merged 13 commits into from
May 22, 2023

Conversation

TinyMarsh
Copy link
Contributor

@TinyMarsh TinyMarsh commented May 19, 2023 •
edited by dalonsoa
Loading

Description

This PR expands the CI system to run the tests in Python 3.8-3.9 as well as in all three platforms: Linux, Windows and MacOS.

Close #104

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Key checklist

  • All tests pass: $ python -m pytest
  • The documentation builds and looks OK: $ python setup.py build_sphinx

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

TinyMarsh and others added 13 commits May 19, 2023 10:42
@TinyMarsh
add matrix to CI to expand tests
43a7820
@TinyMarsh @dalonsoa
Update .github/workflows/ci.yml
70ef6a4 
Co-authored-by: Diego Alonso Álvarez <[email protected]>
@TinyMarsh @dalonsoa
Update .github/workflows/ci.yml
57c677e 
Co-authored-by: Diego Alonso Álvarez <[email protected]>
@TinyMarsh @dalonsoa
Update .github/workflows/ci.yml
e77742e 
Co-authored-by: Diego Alonso Álvarez <[email protected]>
@TinyMarsh @dalonsoa
Update .github/workflows/ci.yml
b4a27ca 
Co-authored-by: Diego Alonso Álvarez <[email protected]>
@TinyMarsh
Run test on push to expand_ci_system branch
f21eeb6
@dalonsoa
Update .github/workflows/ci.yml
0a99291
@TinyMarsh
Fix error in workflow file
098e940
@TinyMarsh
Merge branch 'expand_ci_system' of https://github.com/ImperialCollege…
3d3be62 
…London/MUSE_OS into expand_ci_system
@TinyMarsh
Fix error in workflow
762a34f
@TinyMarsh
Remove targeting Python 3.10 and 3.11
3a5d124
@TinyMarsh
Remove targeting Python 3.10 and 3.11 from regression-tests
f6a6f9b
@TinyMarsh
Remove expand_ci_system branch from list of branches in CI workflow
f9d486f
This was referenced May 19, 2023
Closed
Merged
@dalonsoa dalonsoa linked an issue May 22, 2023 that may be closed by this pull request
Add testing in the CI system to cover Python 3.8-3.11, Linux, Windows and MacOS #104
Closed
@dalonsoa dalonsoa mentioned this pull request May 22, 2023
Closed
4 tasks
@dalonsoa
Copy link
Collaborator

@TinyMarsh , unit tests with Python 3.9 in Windows is failing. I'm re-running the CI, in case it was a flaky test, but if it indeed fails, then we need to open an issue about it and remove Python 3.9 from the list (or indicate somewhere that it works in Python 3.9 but only in MacOS and Linux).

@TinyMarsh
Copy link
Contributor Author

@dalonsoa It looks like tests have now passed for Windows with Python 3.9.

@dalonsoa dalonsoa merged commit ecd998b into EnergySystemsModellingLab:develop_imperial May 22, 2023
@dalonsoa dalonsoa deleted the expand_ci_system branch May 22, 2023 14:08
@dalonsoa dalonsoa mentioned this pull request May 23, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add testing in the CI system to cover Python 3.8-3.11, Linux, Windows and MacOS
2 participants
@TinyMarsh @dalonsoa