Skip to content

(deps) Updating to latest graphql-java:17.1 library #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2021
Merged

(deps) Updating to latest graphql-java:17.1 library #272

merged 2 commits into from
Aug 20, 2021

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Aug 4, 2021

Updating to the recently released graphql-java:17.0 library

As part of 17.0, the following breaking changes occured

  • The deprecated BatchedExecutionStrategy was removed. As such, I've removed @GraphQLBatched
  • Non-standard scalars (BigInteger, BigDecimal, Char, Byte, Long, Short) were all removed. This was communicated within the 15.0 release notes and was finalized in 17.0. As such, I have removed the same in this PR

Appreciate any feedback

In 17.0, GraphQLBatched and non-standard Scalars (BigInteger, BigDecimal, Char, Byte, Long, Short) were all removed.  Accordingly, removed from here
@setchy
Copy link
Contributor Author

setchy commented Aug 4, 2021

Not sure why its trying to run the publish step. @yrashk :)

@yarinvak
Copy link
Member

Hey @setchy thanks for you contribution.
I'm not sure why you've removed the custom scalars? Can you elaborate on this?

@yarinvak yarinvak mentioned this pull request Aug 13, 2021
@setchy
Copy link
Contributor Author

setchy commented Aug 13, 2021

Hi @yarinvak - no problems.

Re: the removal of the custom scalars, I have followed up again this morning on this graphql-java 17.0 release discussion thread as there seems to be a disconnect atm.

Initially there was no mention of the removal in the release notes. The revised release notes suggest they are now homed in the graphql-java-extended-scalars project, but that too hasn't quite happened.

Looks like the intention is to keep the 6 scalars though and re-home them. So with that said, I'll look to update this PR once a new version of extended-scalars is available (will update to graphql-java 17.1 at the same time)

@setchy setchy marked this pull request as draft August 13, 2021 11:42
(deps) Adding graphql-java-extended-scalars 17.0 for non-standard scalars (BigInteger, BigDecimal, Char, Byte, Long, Short).
Removing GraphQLBatched as the deprecated `BatchedExecutionStrategy` was finally removed from graphql-java
@setchy setchy changed the title (deps) Updating to use latest graphql-java:17.0 library (deps) Updating to latest graphql-java:17.1 library Aug 15, 2021
@setchy
Copy link
Contributor Author

setchy commented Aug 15, 2021

@yarinvak - PR updated.

@setchy setchy marked this pull request as ready for review August 15, 2021 11:41
@oliemansm
Copy link

@yarinvak Any chance of getting this PR merged and a release published?

@yarinvak yarinvak changed the base branch from master to development August 20, 2021 13:20
@yarinvak yarinvak merged commit eef0f4c into Enigmatis:development Aug 20, 2021
@yarinvak
Copy link
Member

Hey @setchy , I've merged your PR but then I had to revert it because tests failed.
Please pull changes from our development branch (I fixed the pipeline) and fix the failing tests, then create a new PR and I will merge.

Thanks for your contribution

@setchy setchy mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants