Skip to content

Conversation

geichelberger
Copy link
Contributor

This updates graphql-java to the latest version 24.1 and tries to fix the breaking changes.

@Fgerthoffert
Copy link
Collaborator

Thanks for the PR @geichelberger,

Our current plan is to do a v21.5.1 release, including #310 by @anttip, and then review/merge this PR and release (?).

@geichelberger geichelberger changed the title Update graphql java 24.1 Update graphql java 24.2 Aug 28, 2025
@geichelberger
Copy link
Contributor Author

I updated the PR as a new graphql-java version was released with a minor bug fix.

This is a small bugfix release, to use the latest version of DataLoader that includes nullability annotation improvements.

https://github.com/graphql-java/graphql-java/releases/tag/v24.2

@jkevan
Copy link
Collaborator

jkevan commented Oct 2, 2025

Hi @geichelberger
Thank you very much for your contribution! 🙏

Could you please rebase your branch onto the latest main? This will ensure you benefit from the recent CI/workflow fixes and allow the tests to run properly on your PR.

Additionally, could you update the version in gradle.properties to 24.2 instead of 24.1?

Once these changes are made, we should be able to proceed with the approval and merge.
Thanks again for your efforts!

Copy link
Collaborator

@jkevan jkevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment:

  • version in gradle.properties -> 24.2

- com.graphql-java:graphql-java:22.3
- com.graphql-java:graphql-java-extended-scalars:22.0
@jkevan
Copy link
Collaborator

jkevan commented Oct 3, 2025

Closing, works done in: #315

@jkevan jkevan closed this Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants