-
Notifications
You must be signed in to change notification settings - Fork 128
Merge rust build system #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
required configuration.
Use base path instead of build
Remove reqwest dependency
Add LLVM header requirements to README
Enzyme rust
Create LICENSE-APACHE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZuseZ4 asked me to give my consent for the re-licensing just in case, keep up the good work 👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides comments inline.
Also not sure if you want to do this PR or another, but it would be good to add this to the github actions CI on a release
I guess it makes sense to merge the release CI updates with some build tests which I should also add to CI, so I prefer to bundle those all into a follow-up PR. |
Adds the rust build repo which is published as crate under https://crates.io/crates/enzyme
Should allow further CI automation.