Skip to content

Merge rust build system #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 67 commits into from
Mar 10, 2022
Merged

Merge rust build system #519

merged 67 commits into from
Mar 10, 2022

Conversation

ZuseZ4
Copy link
Collaborator

@ZuseZ4 ZuseZ4 commented Feb 11, 2022

Adds the rust build repo which is published as crate under https://crates.io/crates/enzyme
Should allow further CI automation.

ZuseZ4 and others added 30 commits August 22, 2021 03:23
Use base path instead of build
Add LLVM header requirements to README
Copy link
Collaborator

@bytesnake bytesnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZuseZ4 asked me to give my consent for the re-licensing just in case, keep up the good work 👍

@ZuseZ4
Copy link
Collaborator Author

ZuseZ4 commented Mar 9, 2022

enzyme-install
error: The following required arguments were not provided:
    <--rust-stable|--rust-head|--rust-local <RUST_LOCAL>>
    <--enzyme-stable|--enzyme-head|--enzyme-local <ENZYME_LOCAL>>

USAGE:
    enzyme-install <--rust-stable|--rust-head|--rust-local <RUST_LOCAL>> <--enzyme-stable|--enzyme-head|--enzyme-local <ENZYME_LOCAL>>

@ZuseZ4 ZuseZ4 requested a review from wsmoses March 9, 2022 06:36
Copy link
Member

@wsmoses wsmoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides comments inline.

Also not sure if you want to do this PR or another, but it would be good to add this to the github actions CI on a release

@ZuseZ4 ZuseZ4 enabled auto-merge (squash) March 10, 2022 03:04
@ZuseZ4
Copy link
Collaborator Author

ZuseZ4 commented Mar 10, 2022

I guess it makes sense to merge the release CI updates with some build tests which I should also add to CI, so I prefer to bundle those all into a follow-up PR.

@ZuseZ4 ZuseZ4 merged commit 798c15d into main Mar 10, 2022
@ZuseZ4 ZuseZ4 deleted the merge-rust branch March 10, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants